Compare commits
29 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 6f19f855f1 | |||
| 3cf1eb2312 | |||
| 2af3554f90 | |||
| 180c6ba2ba | |||
| dafc4173ef | |||
| f1a83be671 | |||
| 5aeb70b3f0 | |||
| 8384a5683c | |||
| 4369957cb4 | |||
| a0e8464967 | |||
| c57d0d559f | |||
| 644602b845 | |||
| 36df8eef6e | |||
| 18a2148713 | |||
| bc9958322f | |||
| 6d56ac8027 | |||
| 098464b61b | |||
| 85e2448ce5 | |||
| ee07c9203b | |||
| 014204cfb7 | |||
| 923b2ab478 | |||
| af236b689f | |||
| b730b2be5d | |||
| a437caafe5 | |||
| be6c57be30 | |||
| d55304782e | |||
| 0977c05dd5 | |||
| bccd6e48f4 | |||
| 9b890cf9c5 |
@@ -19,7 +19,7 @@ jobs:
|
|||||||
dry-run: false
|
dry-run: false
|
||||||
language: go
|
language: go
|
||||||
- name: Upload Crash
|
- name: Upload Crash
|
||||||
uses: actions/upload-artifact@v4
|
uses: actions/upload-artifact@v6
|
||||||
if: failure() && steps.build.outcome == 'success'
|
if: failure() && steps.build.outcome == 'success'
|
||||||
with:
|
with:
|
||||||
name: artifacts
|
name: artifacts
|
||||||
|
|||||||
@@ -35,11 +35,11 @@ jobs:
|
|||||||
|
|
||||||
steps:
|
steps:
|
||||||
- name: Checkout repository
|
- name: Checkout repository
|
||||||
uses: actions/checkout@v4
|
uses: actions/checkout@v6
|
||||||
|
|
||||||
# Initializes the CodeQL tools for scanning.
|
# Initializes the CodeQL tools for scanning.
|
||||||
- name: Initialize CodeQL
|
- name: Initialize CodeQL
|
||||||
uses: github/codeql-action/init@v3
|
uses: github/codeql-action/init@v4
|
||||||
with:
|
with:
|
||||||
languages: ${{ matrix.language }}
|
languages: ${{ matrix.language }}
|
||||||
# If you wish to specify custom queries, you can do so here or in a config file.
|
# If you wish to specify custom queries, you can do so here or in a config file.
|
||||||
@@ -47,10 +47,10 @@ jobs:
|
|||||||
# Prefix the list here with "+" to use these queries and those in the config file.
|
# Prefix the list here with "+" to use these queries and those in the config file.
|
||||||
# queries: ./path/to/local/query, your-org/your-repo/queries@main
|
# queries: ./path/to/local/query, your-org/your-repo/queries@main
|
||||||
|
|
||||||
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
|
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
|
||||||
# If this step fails, then you should remove it and run the build manually (see below)
|
# If this step fails, then you should remove it and run the build manually (see below)
|
||||||
- name: Autobuild
|
- name: Autobuild
|
||||||
uses: github/codeql-action/autobuild@v3
|
uses: github/codeql-action/autobuild@v4
|
||||||
|
|
||||||
# ℹ️ Command-line programs to run using the OS shell.
|
# ℹ️ Command-line programs to run using the OS shell.
|
||||||
# 📚 https://git.io/JvXDl
|
# 📚 https://git.io/JvXDl
|
||||||
@@ -64,4 +64,4 @@ jobs:
|
|||||||
# make release
|
# make release
|
||||||
|
|
||||||
- name: Perform CodeQL Analysis
|
- name: Perform CodeQL Analysis
|
||||||
uses: github/codeql-action/analyze@v3
|
uses: github/codeql-action/analyze@v4
|
||||||
|
|||||||
@@ -9,12 +9,12 @@ jobs:
|
|||||||
runs-on: "ubuntu-latest"
|
runs-on: "ubuntu-latest"
|
||||||
name: report
|
name: report
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v4
|
- uses: actions/checkout@v6
|
||||||
with:
|
with:
|
||||||
fetch-depth: 0
|
fetch-depth: 0
|
||||||
- name: Setup go
|
- name: Setup go
|
||||||
uses: actions/setup-go@v5
|
uses: actions/setup-go@v6
|
||||||
with:
|
with:
|
||||||
go-version: "1.22"
|
go-version: "1.24"
|
||||||
- name: Run tests with coverage
|
- name: Run tests with coverage
|
||||||
run: ./ci.sh coverage -d "${GITHUB_BASE_REF-HEAD}"
|
run: ./ci.sh coverage -d "${GITHUB_BASE_REF-HEAD}"
|
||||||
|
|||||||
@@ -0,0 +1,36 @@
|
|||||||
|
name: Go Versions Compatibility Test
|
||||||
|
|
||||||
|
on:
|
||||||
|
workflow_dispatch:
|
||||||
|
inputs:
|
||||||
|
go_versions:
|
||||||
|
description: 'Go versions to test (space-separated, e.g., "1.21 1.22 1.23")'
|
||||||
|
required: false
|
||||||
|
default: ''
|
||||||
|
type: string
|
||||||
|
|
||||||
|
jobs:
|
||||||
|
test:
|
||||||
|
runs-on: ubuntu-latest
|
||||||
|
|
||||||
|
steps:
|
||||||
|
- name: Checkout code
|
||||||
|
uses: actions/checkout@v6
|
||||||
|
with:
|
||||||
|
fetch-depth: 0
|
||||||
|
|
||||||
|
- name: Set up Docker Buildx
|
||||||
|
uses: docker/setup-buildx-action@v3
|
||||||
|
|
||||||
|
- name: Run Go versions compatibility test
|
||||||
|
run: |
|
||||||
|
VERSIONS="${{ github.event.inputs.go_versions }}"
|
||||||
|
./test-go-versions.sh --output ./test-results $VERSIONS
|
||||||
|
|
||||||
|
- name: Upload test results
|
||||||
|
uses: actions/upload-artifact@v6
|
||||||
|
with:
|
||||||
|
name: go-versions-test-results
|
||||||
|
path: |
|
||||||
|
test-results/
|
||||||
|
retention-days: 30
|
||||||
@@ -16,13 +16,13 @@ jobs:
|
|||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
steps:
|
steps:
|
||||||
- name: Checkout
|
- name: Checkout
|
||||||
uses: actions/checkout@v4
|
uses: actions/checkout@v6
|
||||||
with:
|
with:
|
||||||
fetch-depth: 0
|
fetch-depth: 0
|
||||||
- name: Set up Go
|
- name: Set up Go
|
||||||
uses: actions/setup-go@v5
|
uses: actions/setup-go@v6
|
||||||
with:
|
with:
|
||||||
go-version: "1.22"
|
go-version: "1.24"
|
||||||
- name: Login to GitHub Container Registry
|
- name: Login to GitHub Container Registry
|
||||||
uses: docker/login-action@v3
|
uses: docker/login-action@v3
|
||||||
with:
|
with:
|
||||||
@@ -30,10 +30,10 @@ jobs:
|
|||||||
username: ${{ github.actor }}
|
username: ${{ github.actor }}
|
||||||
password: ${{ secrets.GITHUB_TOKEN }}
|
password: ${{ secrets.GITHUB_TOKEN }}
|
||||||
- name: Run GoReleaser
|
- name: Run GoReleaser
|
||||||
uses: goreleaser/goreleaser-action@v3
|
uses: goreleaser/goreleaser-action@v6
|
||||||
with:
|
with:
|
||||||
distribution: goreleaser
|
distribution: goreleaser
|
||||||
version: latest
|
version: '~> v2'
|
||||||
args: release ${{ inputs.args }} --rm-dist
|
args: release ${{ inputs.args }} --clean
|
||||||
env:
|
env:
|
||||||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
|||||||
@@ -12,21 +12,21 @@ jobs:
|
|||||||
strategy:
|
strategy:
|
||||||
matrix:
|
matrix:
|
||||||
os: [ 'ubuntu-latest', 'windows-latest', 'macos-latest', 'macos-14' ]
|
os: [ 'ubuntu-latest', 'windows-latest', 'macos-latest', 'macos-14' ]
|
||||||
go: [ '1.21', '1.22' ]
|
go: [ '1.23', '1.24' ]
|
||||||
runs-on: ${{ matrix.os }}
|
runs-on: ${{ matrix.os }}
|
||||||
name: ${{ matrix.go }}/${{ matrix.os }}
|
name: ${{ matrix.go }}/${{ matrix.os }}
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v4
|
- uses: actions/checkout@v6
|
||||||
with:
|
with:
|
||||||
fetch-depth: 0
|
fetch-depth: 0
|
||||||
- name: Setup go ${{ matrix.go }}
|
- name: Setup go ${{ matrix.go }}
|
||||||
uses: actions/setup-go@v5
|
uses: actions/setup-go@v6
|
||||||
with:
|
with:
|
||||||
go-version: ${{ matrix.go }}
|
go-version: ${{ matrix.go }}
|
||||||
- name: Run unit tests
|
- name: Run unit tests
|
||||||
run: go test -race ./...
|
run: go test -race ./...
|
||||||
release-check:
|
release-check:
|
||||||
if: ${{ github.ref != 'refs/heads/v2' }}
|
if: ${{ github.ref != 'refs/heads/v2' }}
|
||||||
uses: pelletier/go-toml/.github/workflows/release.yml@v2
|
uses: ./.github/workflows/release.yml
|
||||||
with:
|
with:
|
||||||
args: --snapshot
|
args: --snapshot
|
||||||
|
|||||||
@@ -5,3 +5,4 @@ cmd/tomljson/tomljson
|
|||||||
cmd/tomltestgen/tomltestgen
|
cmd/tomltestgen/tomltestgen
|
||||||
dist
|
dist
|
||||||
tests/
|
tests/
|
||||||
|
test-results
|
||||||
|
|||||||
+2
-1
@@ -1,3 +1,4 @@
|
|||||||
|
version: 2
|
||||||
before:
|
before:
|
||||||
hooks:
|
hooks:
|
||||||
- go mod tidy
|
- go mod tidy
|
||||||
@@ -112,7 +113,7 @@ dockers:
|
|||||||
checksum:
|
checksum:
|
||||||
name_template: 'sha256sums.txt'
|
name_template: 'sha256sums.txt'
|
||||||
snapshot:
|
snapshot:
|
||||||
name_template: "{{ incpatch .Version }}-next"
|
version_template: "{{ incpatch .Version }}-next"
|
||||||
release:
|
release:
|
||||||
github:
|
github:
|
||||||
owner: pelletier
|
owner: pelletier
|
||||||
|
|||||||
+51
-9
@@ -33,7 +33,7 @@ The documentation is present in the [README][readme] and thorough the source
|
|||||||
code. On release, it gets updated on [pkg.go.dev][pkg.go.dev]. To make a change
|
code. On release, it gets updated on [pkg.go.dev][pkg.go.dev]. To make a change
|
||||||
to the documentation, create a pull request with your proposed changes. For
|
to the documentation, create a pull request with your proposed changes. For
|
||||||
simple changes like that, the easiest way to go is probably the "Fork this
|
simple changes like that, the easiest way to go is probably the "Fork this
|
||||||
project and edit the file" button on Github, displayed at the top right of the
|
project and edit the file" button on GitHub, displayed at the top right of the
|
||||||
file. Unless it's a trivial change (for example a typo), provide a little bit of
|
file. Unless it's a trivial change (for example a typo), provide a little bit of
|
||||||
context in your pull request description or commit message.
|
context in your pull request description or commit message.
|
||||||
|
|
||||||
@@ -92,6 +92,48 @@ However, given GitHub's new policy to _not_ run Actions on pull requests until a
|
|||||||
maintainer clicks on button, it is highly recommended that you run them locally
|
maintainer clicks on button, it is highly recommended that you run them locally
|
||||||
as you make changes.
|
as you make changes.
|
||||||
|
|
||||||
|
### Test across Go versions
|
||||||
|
|
||||||
|
The repository includes tooling to test go-toml across multiple Go versions
|
||||||
|
(1.11 through 1.25) both locally and in GitHub Actions.
|
||||||
|
|
||||||
|
#### Local testing with Docker
|
||||||
|
|
||||||
|
Prerequisites: Docker installed and running, Bash shell, `rsync` command.
|
||||||
|
|
||||||
|
```bash
|
||||||
|
# Test all Go versions in parallel (default)
|
||||||
|
./test-go-versions.sh
|
||||||
|
|
||||||
|
# Test specific versions
|
||||||
|
./test-go-versions.sh 1.21 1.22 1.23
|
||||||
|
|
||||||
|
# Test sequentially (slower but uses less resources)
|
||||||
|
./test-go-versions.sh --sequential
|
||||||
|
|
||||||
|
# Verbose output with custom results directory
|
||||||
|
./test-go-versions.sh --verbose --output ./my-results 1.24 1.25
|
||||||
|
|
||||||
|
# Show all options
|
||||||
|
./test-go-versions.sh --help
|
||||||
|
```
|
||||||
|
|
||||||
|
The script creates Docker containers for each Go version and runs the full test
|
||||||
|
suite. Results are saved to a `test-results/` directory with individual logs and
|
||||||
|
a comprehensive summary report.
|
||||||
|
|
||||||
|
The script only exits with a non-zero status code if either of the two most
|
||||||
|
recent Go versions fail.
|
||||||
|
|
||||||
|
#### GitHub Actions testing (maintainers)
|
||||||
|
|
||||||
|
1. Go to the **Actions** tab in the GitHub repository
|
||||||
|
2. Select **"Go Versions Compatibility Test"** from the workflow list
|
||||||
|
3. Click **"Run workflow"**
|
||||||
|
4. Optionally customize:
|
||||||
|
- **Go versions**: Space-separated list (e.g., `1.21 1.22 1.23`)
|
||||||
|
- **Execution mode**: Parallel (faster) or sequential (more stable)
|
||||||
|
|
||||||
### Check coverage
|
### Check coverage
|
||||||
|
|
||||||
We use `go tool cover` to compute test coverage. Most code editors have a way to
|
We use `go tool cover` to compute test coverage. Most code editors have a way to
|
||||||
@@ -111,7 +153,7 @@ code lowers the coverage.
|
|||||||
|
|
||||||
Go-toml aims to stay efficient. We rely on a set of scenarios executed with Go's
|
Go-toml aims to stay efficient. We rely on a set of scenarios executed with Go's
|
||||||
builtin benchmark systems. Because of their noisy nature, containers provided by
|
builtin benchmark systems. Because of their noisy nature, containers provided by
|
||||||
Github Actions cannot be reliably used for benchmarking. As a result, you are
|
GitHub Actions cannot be reliably used for benchmarking. As a result, you are
|
||||||
responsible for checking that your changes do not incur a performance penalty.
|
responsible for checking that your changes do not incur a performance penalty.
|
||||||
You can run their following to execute benchmarks:
|
You can run their following to execute benchmarks:
|
||||||
|
|
||||||
@@ -168,13 +210,13 @@ Checklist:
|
|||||||
1. Decide on the next version number. Use semver. Review commits since last
|
1. Decide on the next version number. Use semver. Review commits since last
|
||||||
version to assess.
|
version to assess.
|
||||||
2. Tag release. For example:
|
2. Tag release. For example:
|
||||||
```
|
```
|
||||||
git checkout v2
|
git checkout v2
|
||||||
git pull
|
git pull
|
||||||
git tag v2.2.0
|
git tag v2.2.0
|
||||||
git push --tags
|
git push --tags
|
||||||
```
|
```
|
||||||
3. CI automatically builds a draft Github release. Review it and edit as
|
3. CI automatically builds a draft GitHub release. Review it and edit as
|
||||||
necessary. Look for "Other changes". That would indicate a pull request not
|
necessary. Look for "Other changes". That would indicate a pull request not
|
||||||
labeled properly. Tweak labels and pull request titles until changelog looks
|
labeled properly. Tweak labels and pull request titles until changelog looks
|
||||||
good for users.
|
good for users.
|
||||||
|
|||||||
@@ -107,7 +107,11 @@ type MyConfig struct {
|
|||||||
### Unmarshaling
|
### Unmarshaling
|
||||||
|
|
||||||
[`Unmarshal`][unmarshal] reads a TOML document and fills a Go structure with its
|
[`Unmarshal`][unmarshal] reads a TOML document and fills a Go structure with its
|
||||||
content. For example:
|
content.
|
||||||
|
|
||||||
|
Note that the struct variable names are _capitalized_, while the variables in the toml document are _lowercase_.
|
||||||
|
|
||||||
|
For example:
|
||||||
|
|
||||||
```go
|
```go
|
||||||
doc := `
|
doc := `
|
||||||
@@ -133,6 +137,62 @@ fmt.Println("tags:", cfg.Tags)
|
|||||||
|
|
||||||
[unmarshal]: https://pkg.go.dev/github.com/pelletier/go-toml/v2#Unmarshal
|
[unmarshal]: https://pkg.go.dev/github.com/pelletier/go-toml/v2#Unmarshal
|
||||||
|
|
||||||
|
|
||||||
|
Here is an example using tables with some simple nesting:
|
||||||
|
|
||||||
|
```go
|
||||||
|
doc := `
|
||||||
|
age = 45
|
||||||
|
fruits = ["apple", "pear"]
|
||||||
|
|
||||||
|
# these are very important!
|
||||||
|
[my-variables]
|
||||||
|
first = 1
|
||||||
|
second = 0.2
|
||||||
|
third = "abc"
|
||||||
|
|
||||||
|
# this is not so important.
|
||||||
|
[my-variables.b]
|
||||||
|
bfirst = 123
|
||||||
|
`
|
||||||
|
|
||||||
|
var Document struct {
|
||||||
|
Age int
|
||||||
|
Fruits []string
|
||||||
|
|
||||||
|
Myvariables struct {
|
||||||
|
First int
|
||||||
|
Second float64
|
||||||
|
Third string
|
||||||
|
|
||||||
|
B struct {
|
||||||
|
Bfirst int
|
||||||
|
}
|
||||||
|
} `toml:"my-variables"`
|
||||||
|
}
|
||||||
|
|
||||||
|
err := toml.Unmarshal([]byte(doc), &Document)
|
||||||
|
if err != nil {
|
||||||
|
panic(err)
|
||||||
|
}
|
||||||
|
|
||||||
|
fmt.Println("age:", Document.Age)
|
||||||
|
fmt.Println("fruits:", Document.Fruits)
|
||||||
|
fmt.Println("my-variables.first:", Document.Myvariables.First)
|
||||||
|
fmt.Println("my-variables.second:", Document.Myvariables.Second)
|
||||||
|
fmt.Println("my-variables.third:", Document.Myvariables.Third)
|
||||||
|
fmt.Println("my-variables.B.Bfirst:", Document.Myvariables.B.Bfirst)
|
||||||
|
|
||||||
|
// Output:
|
||||||
|
// age: 45
|
||||||
|
// fruits: [apple pear]
|
||||||
|
// my-variables.first: 1
|
||||||
|
// my-variables.second: 0.2
|
||||||
|
// my-variables.third: abc
|
||||||
|
// my-variables.B.Bfirst: 123
|
||||||
|
```
|
||||||
|
|
||||||
|
|
||||||
### Marshaling
|
### Marshaling
|
||||||
|
|
||||||
[`Marshal`][marshal] is the opposite of Unmarshal: it represents a Go structure
|
[`Marshal`][marshal] is the opposite of Unmarshal: it represents a Go structure
|
||||||
@@ -565,7 +625,7 @@ complete solutions exist out there.
|
|||||||
|
|
||||||
## Versioning
|
## Versioning
|
||||||
|
|
||||||
Expect for parts explicitely marked otherwise, go-toml follows [Semantic
|
Expect for parts explicitly marked otherwise, go-toml follows [Semantic
|
||||||
Versioning](https://semver.org). The supported version of
|
Versioning](https://semver.org). The supported version of
|
||||||
[TOML](https://github.com/toml-lang/toml) is indicated at the beginning of this
|
[TOML](https://github.com/toml-lang/toml) is indicated at the beginning of this
|
||||||
document. The last two major versions of Go are supported (see [Go Release
|
document. The last two major versions of Go are supported (see [Go Release
|
||||||
|
|||||||
@@ -3,13 +3,13 @@ package benchmark_test
|
|||||||
import (
|
import (
|
||||||
"compress/gzip"
|
"compress/gzip"
|
||||||
"encoding/json"
|
"encoding/json"
|
||||||
"io/ioutil"
|
"io"
|
||||||
"os"
|
"os"
|
||||||
"path/filepath"
|
"path/filepath"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
"github.com/pelletier/go-toml/v2"
|
"github.com/pelletier/go-toml/v2"
|
||||||
"github.com/stretchr/testify/require"
|
"github.com/pelletier/go-toml/v2/internal/assert"
|
||||||
)
|
)
|
||||||
|
|
||||||
var bench_inputs = []struct {
|
var bench_inputs = []struct {
|
||||||
@@ -35,11 +35,11 @@ func TestUnmarshalDatasetCode(t *testing.T) {
|
|||||||
buf := fixture(t, tc.name)
|
buf := fixture(t, tc.name)
|
||||||
|
|
||||||
var v interface{}
|
var v interface{}
|
||||||
require.NoError(t, toml.Unmarshal(buf, &v))
|
assert.NoError(t, toml.Unmarshal(buf, &v))
|
||||||
|
|
||||||
b, err := json.Marshal(v)
|
b, err := json.Marshal(v)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, len(b), tc.jsonLen)
|
assert.Equal(t, len(b), tc.jsonLen)
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -53,7 +53,7 @@ func BenchmarkUnmarshalDataset(b *testing.B) {
|
|||||||
b.ResetTimer()
|
b.ResetTimer()
|
||||||
for i := 0; i < b.N; i++ {
|
for i := 0; i < b.N; i++ {
|
||||||
var v interface{}
|
var v interface{}
|
||||||
require.NoError(b, toml.Unmarshal(buf, &v))
|
assert.NoError(b, toml.Unmarshal(buf, &v))
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
@@ -68,13 +68,13 @@ func fixture(tb testing.TB, path string) []byte {
|
|||||||
if os.IsNotExist(err) {
|
if os.IsNotExist(err) {
|
||||||
tb.Skip("benchmark fixture not found:", file)
|
tb.Skip("benchmark fixture not found:", file)
|
||||||
}
|
}
|
||||||
require.NoError(tb, err)
|
assert.NoError(tb, err)
|
||||||
defer f.Close()
|
defer f.Close()
|
||||||
|
|
||||||
gz, err := gzip.NewReader(f)
|
gz, err := gzip.NewReader(f)
|
||||||
require.NoError(tb, err)
|
assert.NoError(tb, err)
|
||||||
|
|
||||||
buf, err := ioutil.ReadAll(gz)
|
buf, err := io.ReadAll(gz)
|
||||||
require.NoError(tb, err)
|
assert.NoError(tb, err)
|
||||||
return buf
|
return buf
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -2,12 +2,12 @@ package benchmark_test
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"bytes"
|
"bytes"
|
||||||
"io/ioutil"
|
"os"
|
||||||
"testing"
|
"testing"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"github.com/pelletier/go-toml/v2"
|
"github.com/pelletier/go-toml/v2"
|
||||||
"github.com/stretchr/testify/require"
|
"github.com/pelletier/go-toml/v2/internal/assert"
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestUnmarshalSimple(t *testing.T) {
|
func TestUnmarshalSimple(t *testing.T) {
|
||||||
@@ -59,7 +59,7 @@ func BenchmarkUnmarshal(b *testing.B) {
|
|||||||
})
|
})
|
||||||
|
|
||||||
b.Run("ReferenceFile", func(b *testing.B) {
|
b.Run("ReferenceFile", func(b *testing.B) {
|
||||||
bytes, err := ioutil.ReadFile("benchmark.toml")
|
bytes, err := os.ReadFile("benchmark.toml")
|
||||||
if err != nil {
|
if err != nil {
|
||||||
b.Fatal(err)
|
b.Fatal(err)
|
||||||
}
|
}
|
||||||
@@ -165,7 +165,7 @@ func BenchmarkMarshal(b *testing.B) {
|
|||||||
})
|
})
|
||||||
|
|
||||||
b.Run("ReferenceFile", func(b *testing.B) {
|
b.Run("ReferenceFile", func(b *testing.B) {
|
||||||
bytes, err := ioutil.ReadFile("benchmark.toml")
|
bytes, err := os.ReadFile("benchmark.toml")
|
||||||
if err != nil {
|
if err != nil {
|
||||||
b.Fatal(err)
|
b.Fatal(err)
|
||||||
}
|
}
|
||||||
@@ -344,11 +344,11 @@ type benchmarkDoc struct {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func TestUnmarshalReferenceFile(t *testing.T) {
|
func TestUnmarshalReferenceFile(t *testing.T) {
|
||||||
bytes, err := ioutil.ReadFile("benchmark.toml")
|
bytes, err := os.ReadFile("benchmark.toml")
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
d := benchmarkDoc{}
|
d := benchmarkDoc{}
|
||||||
err = toml.Unmarshal(bytes, &d)
|
err = toml.Unmarshal(bytes, &d)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
expected := benchmarkDoc{
|
expected := benchmarkDoc{
|
||||||
Table: struct {
|
Table: struct {
|
||||||
@@ -627,7 +627,7 @@ trimmed in raw strings.
|
|||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
require.Equal(t, expected, d)
|
assert.Equal(t, expected, d)
|
||||||
}
|
}
|
||||||
|
|
||||||
var hugoFrontMatterbytes = []byte(`
|
var hugoFrontMatterbytes = []byte(`
|
||||||
|
|||||||
@@ -5,8 +5,7 @@ import (
|
|||||||
"strings"
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
"github.com/stretchr/testify/assert"
|
"github.com/pelletier/go-toml/v2/internal/assert"
|
||||||
"github.com/stretchr/testify/require"
|
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestConvert(t *testing.T) {
|
func TestConvert(t *testing.T) {
|
||||||
@@ -54,7 +53,7 @@ a = 42
|
|||||||
useJsonNumber = e.useJsonNumber
|
useJsonNumber = e.useJsonNumber
|
||||||
err := convert(strings.NewReader(e.input), b)
|
err := convert(strings.NewReader(e.input), b)
|
||||||
if e.errors {
|
if e.errors {
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
} else {
|
} else {
|
||||||
assert.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, e.expected, b.String())
|
assert.Equal(t, e.expected, b.String())
|
||||||
|
|||||||
@@ -7,8 +7,7 @@ import (
|
|||||||
"strings"
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
"github.com/stretchr/testify/assert"
|
"github.com/pelletier/go-toml/v2/internal/assert"
|
||||||
"github.com/stretchr/testify/require"
|
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestConvert(t *testing.T) {
|
func TestConvert(t *testing.T) {
|
||||||
@@ -46,7 +45,7 @@ a = 42`),
|
|||||||
b := new(bytes.Buffer)
|
b := new(bytes.Buffer)
|
||||||
err := convert(e.input, b)
|
err := convert(e.input, b)
|
||||||
if e.errors {
|
if e.errors {
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
} else {
|
} else {
|
||||||
assert.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, e.expected, b.String())
|
assert.Equal(t, e.expected, b.String())
|
||||||
|
|||||||
@@ -5,8 +5,7 @@ import (
|
|||||||
"strings"
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
"github.com/stretchr/testify/assert"
|
"github.com/pelletier/go-toml/v2/internal/assert"
|
||||||
"github.com/stretchr/testify/require"
|
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestConvert(t *testing.T) {
|
func TestConvert(t *testing.T) {
|
||||||
@@ -36,7 +35,7 @@ a = 42.0
|
|||||||
b := new(bytes.Buffer)
|
b := new(bytes.Buffer)
|
||||||
err := convert(strings.NewReader(e.input), b)
|
err := convert(strings.NewReader(e.input), b)
|
||||||
if e.errors {
|
if e.errors {
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
} else {
|
} else {
|
||||||
assert.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, e.expected, b.String())
|
assert.Equal(t, e.expected, b.String())
|
||||||
|
|||||||
@@ -106,6 +106,7 @@ func main() {
|
|||||||
for _, f := range dirContent {
|
for _, f := range dirContent {
|
||||||
filename := strings.TrimPrefix(f, "tests/valid/")
|
filename := strings.TrimPrefix(f, "tests/valid/")
|
||||||
name := kebabToCamel(strings.TrimSuffix(filename, ".toml"))
|
name := kebabToCamel(strings.TrimSuffix(filename, ".toml"))
|
||||||
|
name = strings.ReplaceAll(name, ".", "_")
|
||||||
|
|
||||||
log.Printf("> [%s] %s\n", "invalid", name)
|
log.Printf("> [%s] %s\n", "invalid", name)
|
||||||
|
|
||||||
@@ -126,6 +127,7 @@ func main() {
|
|||||||
for _, f := range dirContent {
|
for _, f := range dirContent {
|
||||||
filename := strings.TrimPrefix(f, "tests/valid/")
|
filename := strings.TrimPrefix(f, "tests/valid/")
|
||||||
name := kebabToCamel(strings.TrimSuffix(filename, ".toml"))
|
name := kebabToCamel(strings.TrimSuffix(filename, ".toml"))
|
||||||
|
name = strings.ReplaceAll(name, ".", "_")
|
||||||
|
|
||||||
log.Printf("> [%s] %s\n", "valid", name)
|
log.Printf("> [%s] %s\n", "valid", name)
|
||||||
|
|
||||||
|
|||||||
@@ -144,13 +144,23 @@ func parseDateTime(b []byte) (time.Time, error) {
|
|||||||
return time.Time{}, unstable.NewParserError(b, "extra bytes at the end of the timezone")
|
return time.Time{}, unstable.NewParserError(b, "extra bytes at the end of the timezone")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Normalize leap seconds (second=60) to second=59 to prevent overflow
|
||||||
|
// when Go's time.Date normalizes the time. This is necessary because
|
||||||
|
// time.Date(9999, 12, 31, 23, 59, 60, 0, UTC) normalizes to year 10000,
|
||||||
|
// which is outside the valid TOML date range (0000-9999).
|
||||||
|
// See: https://github.com/pelletier/go-toml/issues/1015
|
||||||
|
second := dt.Second
|
||||||
|
if second == 60 {
|
||||||
|
second = 59
|
||||||
|
}
|
||||||
|
|
||||||
t := time.Date(
|
t := time.Date(
|
||||||
dt.Year,
|
dt.Year,
|
||||||
time.Month(dt.Month),
|
time.Month(dt.Month),
|
||||||
dt.Day,
|
dt.Day,
|
||||||
dt.Hour,
|
dt.Hour,
|
||||||
dt.Minute,
|
dt.Minute,
|
||||||
dt.Second,
|
second,
|
||||||
dt.Nanosecond,
|
dt.Nanosecond,
|
||||||
zone)
|
zone)
|
||||||
|
|
||||||
|
|||||||
@@ -54,6 +54,17 @@ func (s *StrictMissingError) String() string {
|
|||||||
return buf.String()
|
return buf.String()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Unwrap returns wrapped decode errors
|
||||||
|
//
|
||||||
|
// Implements errors.Join() interface.
|
||||||
|
func (s *StrictMissingError) Unwrap() []error {
|
||||||
|
var errs []error
|
||||||
|
for i := range s.Errors {
|
||||||
|
errs = append(errs, &s.Errors[i])
|
||||||
|
}
|
||||||
|
return errs
|
||||||
|
}
|
||||||
|
|
||||||
type Key []string
|
type Key []string
|
||||||
|
|
||||||
// Error returns the error message contained in the DecodeError.
|
// Error returns the error message contained in the DecodeError.
|
||||||
@@ -78,7 +89,7 @@ func (e *DecodeError) Key() Key {
|
|||||||
return e.key
|
return e.key
|
||||||
}
|
}
|
||||||
|
|
||||||
// decodeErrorFromHighlight creates a DecodeError referencing a highlighted
|
// wrapDecodeError creates a DecodeError referencing a highlighted
|
||||||
// range of bytes from document.
|
// range of bytes from document.
|
||||||
//
|
//
|
||||||
// highlight needs to be a sub-slice of document, or this function panics.
|
// highlight needs to be a sub-slice of document, or this function panics.
|
||||||
|
|||||||
+16
-1
@@ -7,8 +7,8 @@ import (
|
|||||||
"strings"
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
|
"github.com/pelletier/go-toml/v2/internal/assert"
|
||||||
"github.com/pelletier/go-toml/v2/unstable"
|
"github.com/pelletier/go-toml/v2/unstable"
|
||||||
"github.com/stretchr/testify/assert"
|
|
||||||
)
|
)
|
||||||
|
|
||||||
//nolint:funlen
|
//nolint:funlen
|
||||||
@@ -205,6 +205,21 @@ func TestDecodeError_Accessors(t *testing.T) {
|
|||||||
assert.Equal(t, "bar", e.String())
|
assert.Equal(t, "bar", e.String())
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestStrictErrorUnwrap(t *testing.T) {
|
||||||
|
fo := bytes.NewBufferString(`
|
||||||
|
Missing = 1
|
||||||
|
OtherMissing = 1
|
||||||
|
`)
|
||||||
|
var out struct{}
|
||||||
|
err := NewDecoder(fo).DisallowUnknownFields().Decode(&out)
|
||||||
|
assert.Error(t, err)
|
||||||
|
|
||||||
|
strictErr := &StrictMissingError{}
|
||||||
|
assert.True(t, errors.As(err, &strictErr))
|
||||||
|
|
||||||
|
assert.Equal(t, 2, len(strictErr.Unwrap()))
|
||||||
|
}
|
||||||
|
|
||||||
func ExampleDecodeError() {
|
func ExampleDecodeError() {
|
||||||
doc := `name = 123__456`
|
doc := `name = 123__456`
|
||||||
|
|
||||||
|
|||||||
+15
-15
@@ -4,28 +4,28 @@ import (
|
|||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
"github.com/pelletier/go-toml/v2"
|
"github.com/pelletier/go-toml/v2"
|
||||||
"github.com/stretchr/testify/require"
|
"github.com/pelletier/go-toml/v2/internal/assert"
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestFastSimpleInt(t *testing.T) {
|
func TestFastSimpleInt(t *testing.T) {
|
||||||
m := map[string]int64{}
|
m := map[string]int64{}
|
||||||
err := toml.Unmarshal([]byte(`a = 42`), &m)
|
err := toml.Unmarshal([]byte(`a = 42`), &m)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, map[string]int64{"a": 42}, m)
|
assert.Equal(t, map[string]int64{"a": 42}, m)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestFastSimpleFloat(t *testing.T) {
|
func TestFastSimpleFloat(t *testing.T) {
|
||||||
m := map[string]float64{}
|
m := map[string]float64{}
|
||||||
err := toml.Unmarshal([]byte("a = 42\nb = 1.1\nc = 12341234123412341234123412341234"), &m)
|
err := toml.Unmarshal([]byte("a = 42\nb = 1.1\nc = 12341234123412341234123412341234"), &m)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, map[string]float64{"a": 42, "b": 1.1, "c": 1.2341234123412342e+31}, m)
|
assert.Equal(t, map[string]float64{"a": 42, "b": 1.1, "c": 1.2341234123412342e+31}, m)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestFastSimpleString(t *testing.T) {
|
func TestFastSimpleString(t *testing.T) {
|
||||||
m := map[string]string{}
|
m := map[string]string{}
|
||||||
err := toml.Unmarshal([]byte(`a = "hello"`), &m)
|
err := toml.Unmarshal([]byte(`a = "hello"`), &m)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, map[string]string{"a": "hello"}, m)
|
assert.Equal(t, map[string]string{"a": "hello"}, m)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestFastSimpleInterface(t *testing.T) {
|
func TestFastSimpleInterface(t *testing.T) {
|
||||||
@@ -33,8 +33,8 @@ func TestFastSimpleInterface(t *testing.T) {
|
|||||||
err := toml.Unmarshal([]byte(`
|
err := toml.Unmarshal([]byte(`
|
||||||
a = "hello"
|
a = "hello"
|
||||||
b = 42`), &m)
|
b = 42`), &m)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, map[string]interface{}{
|
assert.Equal(t, map[string]interface{}{
|
||||||
"a": "hello",
|
"a": "hello",
|
||||||
"b": int64(42),
|
"b": int64(42),
|
||||||
}, m)
|
}, m)
|
||||||
@@ -46,8 +46,8 @@ func TestFastMultipartKeyInterface(t *testing.T) {
|
|||||||
a.interim = "test"
|
a.interim = "test"
|
||||||
a.b.c = "hello"
|
a.b.c = "hello"
|
||||||
b = 42`), &m)
|
b = 42`), &m)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, map[string]interface{}{
|
assert.Equal(t, map[string]interface{}{
|
||||||
"a": map[string]interface{}{
|
"a": map[string]interface{}{
|
||||||
"interim": "test",
|
"interim": "test",
|
||||||
"b": map[string]interface{}{
|
"b": map[string]interface{}{
|
||||||
@@ -66,8 +66,8 @@ func TestFastExistingMap(t *testing.T) {
|
|||||||
ints.one = 1
|
ints.one = 1
|
||||||
ints.two = 2
|
ints.two = 2
|
||||||
strings.yo = "hello"`), &m)
|
strings.yo = "hello"`), &m)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, map[string]interface{}{
|
assert.Equal(t, map[string]interface{}{
|
||||||
"ints": map[string]interface{}{
|
"ints": map[string]interface{}{
|
||||||
"one": int64(1),
|
"one": int64(1),
|
||||||
"two": int64(2),
|
"two": int64(2),
|
||||||
@@ -90,9 +90,9 @@ func TestFastArrayTable(t *testing.T) {
|
|||||||
m := map[string]interface{}{}
|
m := map[string]interface{}{}
|
||||||
|
|
||||||
err := toml.Unmarshal(b, &m)
|
err := toml.Unmarshal(b, &m)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
require.Equal(t, map[string]interface{}{
|
assert.Equal(t, map[string]interface{}{
|
||||||
"root": map[string]interface{}{
|
"root": map[string]interface{}{
|
||||||
"nested": []interface{}{
|
"nested": []interface{}{
|
||||||
map[string]interface{}{
|
map[string]interface{}{
|
||||||
|
|||||||
+4
-7
@@ -1,19 +1,16 @@
|
|||||||
//go:build go1.18 || go1.19 || go1.20 || go1.21 || go1.22
|
|
||||||
// +build go1.18 go1.19 go1.20 go1.21 go1.22
|
|
||||||
|
|
||||||
package toml_test
|
package toml_test
|
||||||
|
|
||||||
import (
|
import (
|
||||||
"io/ioutil"
|
"os"
|
||||||
"strings"
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
"github.com/pelletier/go-toml/v2"
|
"github.com/pelletier/go-toml/v2"
|
||||||
"github.com/stretchr/testify/require"
|
"github.com/pelletier/go-toml/v2/internal/assert"
|
||||||
)
|
)
|
||||||
|
|
||||||
func FuzzUnmarshal(f *testing.F) {
|
func FuzzUnmarshal(f *testing.F) {
|
||||||
file, err := ioutil.ReadFile("benchmark/benchmark.toml")
|
file, err := os.ReadFile("benchmark/benchmark.toml")
|
||||||
if err != nil {
|
if err != nil {
|
||||||
panic(err)
|
panic(err)
|
||||||
}
|
}
|
||||||
@@ -51,6 +48,6 @@ func FuzzUnmarshal(f *testing.F) {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("failed round trip: %s", err)
|
t.Fatalf("failed round trip: %s", err)
|
||||||
}
|
}
|
||||||
require.Equal(t, v, v2)
|
assert.Equal(t, v, v2)
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,5 +1,3 @@
|
|||||||
module github.com/pelletier/go-toml/v2
|
module github.com/pelletier/go-toml/v2
|
||||||
|
|
||||||
go 1.16
|
go 1.21.0
|
||||||
|
|
||||||
require github.com/stretchr/testify v1.9.0
|
|
||||||
|
|||||||
@@ -1,19 +0,0 @@
|
|||||||
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
|
|
||||||
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
|
|
||||||
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
|
|
||||||
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
|
|
||||||
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
|
|
||||||
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
|
|
||||||
github.com/stretchr/objx v0.4.0/go.mod h1:YvHI0jy2hoMjB+UWwv71VJQ9isScKT/TqJzVSSt89Yw=
|
|
||||||
github.com/stretchr/objx v0.5.0/go.mod h1:Yh+to48EsGEfYuaHDzXPcE3xhTkx73EhmCGUpEOglKo=
|
|
||||||
github.com/stretchr/objx v0.5.2/go.mod h1:FRsXN1f5AsAjCGJKqEizvkpNtU+EGNCLh3NxZ/8L+MA=
|
|
||||||
github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
|
|
||||||
github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO+kdMU+MU=
|
|
||||||
github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
|
|
||||||
github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg=
|
|
||||||
github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
|
|
||||||
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
|
|
||||||
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
|
|
||||||
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
|
|
||||||
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
|
|
||||||
gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
|
|
||||||
|
|||||||
@@ -0,0 +1,135 @@
|
|||||||
|
package assert
|
||||||
|
|
||||||
|
import (
|
||||||
|
"bytes"
|
||||||
|
"fmt"
|
||||||
|
"reflect"
|
||||||
|
"strings"
|
||||||
|
"testing"
|
||||||
|
)
|
||||||
|
|
||||||
|
// True asserts that an expression is true.
|
||||||
|
func True(t testing.TB, ok bool, msgAndArgs ...any) {
|
||||||
|
if ok {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
t.Helper()
|
||||||
|
t.Fatal(formatMsgAndArgs("Expected expression to be true", msgAndArgs...))
|
||||||
|
}
|
||||||
|
|
||||||
|
// False asserts that an expression is false.
|
||||||
|
func False(t testing.TB, ok bool, msgAndArgs ...any) {
|
||||||
|
if !ok {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
t.Helper()
|
||||||
|
t.Fatal(formatMsgAndArgs("Expected expression to be false", msgAndArgs...))
|
||||||
|
}
|
||||||
|
|
||||||
|
// Equal asserts that "expected" and "actual" are equal.
|
||||||
|
func Equal[T any](t testing.TB, expected, actual T, msgAndArgs ...any) {
|
||||||
|
if objectsAreEqual(expected, actual) {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
t.Helper()
|
||||||
|
msg := formatMsgAndArgs("Expected values to be equal:", msgAndArgs...)
|
||||||
|
t.Fatalf("%s\n%s", msg, diff(expected, actual))
|
||||||
|
}
|
||||||
|
|
||||||
|
// Error asserts that an error is not nil.
|
||||||
|
func Error(t testing.TB, err error, msgAndArgs ...any) {
|
||||||
|
if err != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
t.Helper()
|
||||||
|
t.Fatal(formatMsgAndArgs("Expected an error", msgAndArgs...))
|
||||||
|
}
|
||||||
|
|
||||||
|
// NoError asserts that an error is nil.
|
||||||
|
func NoError(t testing.TB, err error, msgAndArgs ...any) {
|
||||||
|
if err == nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
t.Helper()
|
||||||
|
msg := formatMsgAndArgs("Unexpected error:", msgAndArgs...)
|
||||||
|
t.Fatalf("%s\n%+v", msg, err)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Panics asserts that the given function panics.
|
||||||
|
func Panics(t testing.TB, fn func(), msgAndArgs ...any) {
|
||||||
|
t.Helper()
|
||||||
|
defer func() {
|
||||||
|
if recover() == nil {
|
||||||
|
msg := formatMsgAndArgs("Expected function to panic", msgAndArgs...)
|
||||||
|
t.Fatal(msg)
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
fn()
|
||||||
|
}
|
||||||
|
|
||||||
|
// Zero asserts that a value is its zero value.
|
||||||
|
func Zero[T any](t testing.TB, value T, msgAndArgs ...any) {
|
||||||
|
var zero T
|
||||||
|
if objectsAreEqual(value, zero) {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
val := reflect.ValueOf(value)
|
||||||
|
if (val.Kind() == reflect.Slice || val.Kind() == reflect.Map || val.Kind() == reflect.Array) && val.Len() == 0 {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
t.Helper()
|
||||||
|
msg := formatMsgAndArgs("Expected zero value but got:", msgAndArgs...)
|
||||||
|
t.Fatalf("%s\n%v", msg, value)
|
||||||
|
}
|
||||||
|
|
||||||
|
func NotZero[T any](t testing.TB, value T, msgAndArgs ...any) {
|
||||||
|
var zero T
|
||||||
|
if !objectsAreEqual(value, zero) {
|
||||||
|
val := reflect.ValueOf(value)
|
||||||
|
if !((val.Kind() == reflect.Slice || val.Kind() == reflect.Map || val.Kind() == reflect.Array) && val.Len() == 0) {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
}
|
||||||
|
t.Helper()
|
||||||
|
msg := formatMsgAndArgs("Unexpected zero value:", msgAndArgs...)
|
||||||
|
t.Fatalf("%s\n%v", msg, value)
|
||||||
|
}
|
||||||
|
|
||||||
|
func formatMsgAndArgs(msg string, args ...any) string {
|
||||||
|
if len(args) == 0 {
|
||||||
|
return msg
|
||||||
|
}
|
||||||
|
format, ok := args[0].(string)
|
||||||
|
if !ok {
|
||||||
|
panic("message argument must be a fmt string")
|
||||||
|
}
|
||||||
|
return fmt.Sprintf(format, args[1:]...)
|
||||||
|
}
|
||||||
|
|
||||||
|
func diff(expected, actual any) string {
|
||||||
|
lines := []string{
|
||||||
|
"expected:",
|
||||||
|
fmt.Sprintf("%v", expected),
|
||||||
|
"actual:",
|
||||||
|
fmt.Sprintf("%v", actual),
|
||||||
|
}
|
||||||
|
return strings.Join(lines, "\n")
|
||||||
|
}
|
||||||
|
|
||||||
|
func objectsAreEqual(expected, actual any) bool {
|
||||||
|
if expected == nil || actual == nil {
|
||||||
|
return expected == actual
|
||||||
|
}
|
||||||
|
if exp, eok := expected.([]byte); eok {
|
||||||
|
if act, aok := actual.([]byte); aok {
|
||||||
|
return bytes.Equal(exp, act)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if exp, eok := expected.(string); eok {
|
||||||
|
if act, aok := actual.(string); aok {
|
||||||
|
return exp == act
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return reflect.DeepEqual(expected, actual)
|
||||||
|
}
|
||||||
@@ -0,0 +1,184 @@
|
|||||||
|
package assert
|
||||||
|
|
||||||
|
import (
|
||||||
|
"fmt"
|
||||||
|
"testing"
|
||||||
|
)
|
||||||
|
|
||||||
|
type Data struct {
|
||||||
|
Label string
|
||||||
|
Value int64
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestBadMessage(t *testing.T) {
|
||||||
|
invalidMessage := func() { True(t, false, 1234) }
|
||||||
|
assertOk(t, "Non-fmt message value", func(t testing.TB) {
|
||||||
|
Panics(t, invalidMessage)
|
||||||
|
})
|
||||||
|
assertFail(t, "Non-fmt message value", func(t testing.TB) {
|
||||||
|
True(t, false, "example %s", "message")
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestTrue(t *testing.T) {
|
||||||
|
assertOk(t, "Succeed", func(t testing.TB) {
|
||||||
|
True(t, 1 > 0)
|
||||||
|
})
|
||||||
|
assertFail(t, "Fail", func(t testing.TB) {
|
||||||
|
True(t, 1 < 0)
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestFalse(t *testing.T) {
|
||||||
|
assertOk(t, "Succeed", func(t testing.TB) {
|
||||||
|
False(t, 1 < 0)
|
||||||
|
})
|
||||||
|
assertFail(t, "Fail", func(t testing.TB) {
|
||||||
|
False(t, 1 > 0)
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestEqual(t *testing.T) {
|
||||||
|
assertOk(t, "Nil", func(t testing.TB) {
|
||||||
|
Equal(t, interface{}(nil), interface{}(nil))
|
||||||
|
})
|
||||||
|
assertOk(t, "Identical structs", func(t testing.TB) {
|
||||||
|
Equal(t, Data{"expected", 1234}, Data{"expected", 1234})
|
||||||
|
})
|
||||||
|
assertFail(t, "Different structs", func(t testing.TB) {
|
||||||
|
Equal(t, Data{"expected", 1234}, Data{"actual", 1234})
|
||||||
|
})
|
||||||
|
assertOk(t, "Identical numbers", func(t testing.TB) {
|
||||||
|
Equal(t, 1234, 1234)
|
||||||
|
})
|
||||||
|
assertFail(t, "Identical numbers", func(t testing.TB) {
|
||||||
|
Equal(t, 1234, 1324)
|
||||||
|
})
|
||||||
|
assertOk(t, "Zero-length byte arrays", func(t testing.TB) {
|
||||||
|
Equal(t, []byte(nil), []byte(""))
|
||||||
|
})
|
||||||
|
assertOk(t, "Identical byte arrays", func(t testing.TB) {
|
||||||
|
Equal(t, []byte{1, 2, 3, 4}, []byte{1, 2, 3, 4})
|
||||||
|
})
|
||||||
|
assertFail(t, "Different byte arrays", func(t testing.TB) {
|
||||||
|
Equal(t, []byte{1, 2, 3, 4}, []byte{1, 3, 2, 4})
|
||||||
|
})
|
||||||
|
assertOk(t, "Identical strings", func(t testing.TB) {
|
||||||
|
Equal(t, "example", "example")
|
||||||
|
})
|
||||||
|
assertFail(t, "Identical strings", func(t testing.TB) {
|
||||||
|
Equal(t, "example", "elpmaxe")
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestError(t *testing.T) {
|
||||||
|
assertOk(t, "Error", func(t testing.TB) {
|
||||||
|
Error(t, fmt.Errorf("example"))
|
||||||
|
})
|
||||||
|
assertFail(t, "Nil", func(t testing.TB) {
|
||||||
|
Error(t, nil)
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestNoError(t *testing.T) {
|
||||||
|
assertFail(t, "Error", func(t testing.TB) {
|
||||||
|
NoError(t, fmt.Errorf("example"))
|
||||||
|
})
|
||||||
|
assertOk(t, "Nil", func(t testing.TB) {
|
||||||
|
NoError(t, nil)
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestPanics(t *testing.T) {
|
||||||
|
willPanic := func() { panic("example") }
|
||||||
|
wontPanic := func() {}
|
||||||
|
assertOk(t, "Will panic", func(t testing.TB) {
|
||||||
|
Panics(t, willPanic)
|
||||||
|
})
|
||||||
|
assertFail(t, "Won't panic", func(t testing.TB) {
|
||||||
|
Panics(t, wontPanic)
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestZero(t *testing.T) {
|
||||||
|
assertOk(t, "Empty struct", func(t testing.TB) {
|
||||||
|
Zero(t, Data{})
|
||||||
|
})
|
||||||
|
assertFail(t, "Non-empty struct", func(t testing.TB) {
|
||||||
|
Zero(t, Data{Label: "example"})
|
||||||
|
})
|
||||||
|
assertOk(t, "Nil slice", func(t testing.TB) {
|
||||||
|
var slice []int
|
||||||
|
Zero(t, slice)
|
||||||
|
})
|
||||||
|
assertFail(t, "Non-empty slice", func(t testing.TB) {
|
||||||
|
slice := []int{1, 2, 3, 4}
|
||||||
|
Zero(t, slice)
|
||||||
|
})
|
||||||
|
assertOk(t, "Zero-length slice", func(t testing.TB) {
|
||||||
|
slice := []int{}
|
||||||
|
Zero(t, slice)
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestNotZero(t *testing.T) {
|
||||||
|
assertFail(t, "Empty struct", func(t testing.TB) {
|
||||||
|
zero := Data{}
|
||||||
|
NotZero(t, zero)
|
||||||
|
})
|
||||||
|
assertOk(t, "Non-empty struct", func(t testing.TB) {
|
||||||
|
notZero := Data{Label: "example"}
|
||||||
|
NotZero(t, notZero)
|
||||||
|
})
|
||||||
|
assertFail(t, "Nil slice", func(t testing.TB) {
|
||||||
|
var slice []int
|
||||||
|
NotZero(t, slice)
|
||||||
|
})
|
||||||
|
assertFail(t, "Zero-length slice", func(t testing.TB) {
|
||||||
|
slice := []int{}
|
||||||
|
NotZero(t, slice)
|
||||||
|
})
|
||||||
|
assertOk(t, "Non-empty slice", func(t testing.TB) {
|
||||||
|
slice := []int{1, 2, 3, 4}
|
||||||
|
NotZero(t, slice)
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
type testCase struct {
|
||||||
|
*testing.T
|
||||||
|
failed string
|
||||||
|
}
|
||||||
|
|
||||||
|
func (t *testCase) Fatal(args ...interface{}) {
|
||||||
|
t.failed = fmt.Sprint(args...)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (t *testCase) Fatalf(message string, args ...interface{}) {
|
||||||
|
t.failed = fmt.Sprintf(message, args...)
|
||||||
|
}
|
||||||
|
|
||||||
|
func assertFail(t *testing.T, name string, fn func(t testing.TB)) {
|
||||||
|
t.Helper()
|
||||||
|
t.Run(name, func(t *testing.T) {
|
||||||
|
t.Helper()
|
||||||
|
test := &testCase{T: t}
|
||||||
|
fn(test)
|
||||||
|
if test.failed == "" {
|
||||||
|
t.Fatal("Test expected to fail but did not")
|
||||||
|
} else {
|
||||||
|
t.Log(test.failed)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
func assertOk(t *testing.T, name string, fn func(t testing.TB)) {
|
||||||
|
t.Helper()
|
||||||
|
t.Run(name, func(t *testing.T) {
|
||||||
|
t.Helper()
|
||||||
|
test := &testCase{T: t}
|
||||||
|
fn(test)
|
||||||
|
if test.failed != "" {
|
||||||
|
t.Fatal("Test expected to succeed but did not:\n", test.failed)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
+3
-4
@@ -6,7 +6,6 @@ import (
|
|||||||
"flag"
|
"flag"
|
||||||
"fmt"
|
"fmt"
|
||||||
"io"
|
"io"
|
||||||
"io/ioutil"
|
|
||||||
"os"
|
"os"
|
||||||
|
|
||||||
"github.com/pelletier/go-toml/v2"
|
"github.com/pelletier/go-toml/v2"
|
||||||
@@ -23,7 +22,7 @@ type Program struct {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (p *Program) Execute() {
|
func (p *Program) Execute() {
|
||||||
flag.Usage = func() { fmt.Fprintf(os.Stderr, p.Usage) }
|
flag.Usage = func() { fmt.Fprint(os.Stderr, p.Usage) }
|
||||||
flag.Parse()
|
flag.Parse()
|
||||||
os.Exit(p.main(flag.Args(), os.Stdin, os.Stdout, os.Stderr))
|
os.Exit(p.main(flag.Args(), os.Stdin, os.Stdout, os.Stderr))
|
||||||
}
|
}
|
||||||
@@ -72,7 +71,7 @@ func (p *Program) runAllFilesInPlace(files []string) error {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (p *Program) runFileInPlace(path string) error {
|
func (p *Program) runFileInPlace(path string) error {
|
||||||
in, err := ioutil.ReadFile(path)
|
in, err := os.ReadFile(path)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
@@ -84,5 +83,5 @@ func (p *Program) runFileInPlace(path string) error {
|
|||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
return ioutil.WriteFile(path, out.Bytes(), 0600)
|
return os.WriteFile(path, out.Bytes(), 0600)
|
||||||
}
|
}
|
||||||
|
|||||||
+37
-39
@@ -4,15 +4,13 @@ import (
|
|||||||
"bytes"
|
"bytes"
|
||||||
"fmt"
|
"fmt"
|
||||||
"io"
|
"io"
|
||||||
"io/ioutil"
|
|
||||||
"os"
|
"os"
|
||||||
"path"
|
"path"
|
||||||
"strings"
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
"github.com/pelletier/go-toml/v2"
|
"github.com/pelletier/go-toml/v2"
|
||||||
"github.com/stretchr/testify/assert"
|
"github.com/pelletier/go-toml/v2/internal/assert"
|
||||||
"github.com/stretchr/testify/require"
|
|
||||||
)
|
)
|
||||||
|
|
||||||
func processMain(args []string, input io.Reader, stdout, stderr io.Writer, f ConvertFn) int {
|
func processMain(args []string, input io.Reader, stdout, stderr io.Writer, f ConvertFn) int {
|
||||||
@@ -30,8 +28,8 @@ func TestProcessMainStdin(t *testing.T) {
|
|||||||
})
|
})
|
||||||
|
|
||||||
assert.Equal(t, 0, exit)
|
assert.Equal(t, 0, exit)
|
||||||
assert.Empty(t, stdout.String())
|
assert.Zero(t, stdout.String())
|
||||||
assert.Empty(t, stderr.String())
|
assert.Zero(t, stderr.String())
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestProcessMainStdinErr(t *testing.T) {
|
func TestProcessMainStdinErr(t *testing.T) {
|
||||||
@@ -44,8 +42,8 @@ func TestProcessMainStdinErr(t *testing.T) {
|
|||||||
})
|
})
|
||||||
|
|
||||||
assert.Equal(t, -1, exit)
|
assert.Equal(t, -1, exit)
|
||||||
assert.Empty(t, stdout.String())
|
assert.Zero(t, stdout.String())
|
||||||
assert.NotEmpty(t, stderr.String())
|
assert.NotZero(t, stderr.String())
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestProcessMainStdinDecodeErr(t *testing.T) {
|
func TestProcessMainStdinDecodeErr(t *testing.T) {
|
||||||
@@ -59,16 +57,16 @@ func TestProcessMainStdinDecodeErr(t *testing.T) {
|
|||||||
})
|
})
|
||||||
|
|
||||||
assert.Equal(t, -1, exit)
|
assert.Equal(t, -1, exit)
|
||||||
assert.Empty(t, stdout.String())
|
assert.Zero(t, stdout.String())
|
||||||
assert.Contains(t, stderr.String(), "error occurred at")
|
assert.True(t, strings.Contains(stderr.String(), "error occurred at"))
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestProcessMainFileExists(t *testing.T) {
|
func TestProcessMainFileExists(t *testing.T) {
|
||||||
tmpfile, err := ioutil.TempFile("", "example")
|
tmpfile, err := os.CreateTemp("", "example")
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
defer os.Remove(tmpfile.Name())
|
defer os.Remove(tmpfile.Name())
|
||||||
_, err = tmpfile.Write([]byte(`some data`))
|
_, err = tmpfile.Write([]byte(`some data`))
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
stdout := new(bytes.Buffer)
|
stdout := new(bytes.Buffer)
|
||||||
stderr := new(bytes.Buffer)
|
stderr := new(bytes.Buffer)
|
||||||
@@ -78,8 +76,8 @@ func TestProcessMainFileExists(t *testing.T) {
|
|||||||
})
|
})
|
||||||
|
|
||||||
assert.Equal(t, 0, exit)
|
assert.Equal(t, 0, exit)
|
||||||
assert.Empty(t, stdout.String())
|
assert.Zero(t, stdout.String())
|
||||||
assert.Empty(t, stderr.String())
|
assert.Zero(t, stderr.String())
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestProcessMainFileDoesNotExist(t *testing.T) {
|
func TestProcessMainFileDoesNotExist(t *testing.T) {
|
||||||
@@ -91,22 +89,22 @@ func TestProcessMainFileDoesNotExist(t *testing.T) {
|
|||||||
})
|
})
|
||||||
|
|
||||||
assert.Equal(t, -1, exit)
|
assert.Equal(t, -1, exit)
|
||||||
assert.Empty(t, stdout.String())
|
assert.Zero(t, stdout.String())
|
||||||
assert.NotEmpty(t, stderr.String())
|
assert.NotZero(t, stderr.String())
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestProcessMainFilesInPlace(t *testing.T) {
|
func TestProcessMainFilesInPlace(t *testing.T) {
|
||||||
dir, err := ioutil.TempDir("", "")
|
dir, err := os.MkdirTemp("", "")
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
defer os.RemoveAll(dir)
|
defer os.RemoveAll(dir)
|
||||||
|
|
||||||
path1 := path.Join(dir, "file1")
|
path1 := path.Join(dir, "file1")
|
||||||
path2 := path.Join(dir, "file2")
|
path2 := path.Join(dir, "file2")
|
||||||
|
|
||||||
err = ioutil.WriteFile(path1, []byte("content 1"), 0600)
|
err = os.WriteFile(path1, []byte("content 1"), 0600)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
err = ioutil.WriteFile(path2, []byte("content 2"), 0600)
|
err = os.WriteFile(path2, []byte("content 2"), 0600)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
p := Program{
|
p := Program{
|
||||||
Fn: dummyFileFn,
|
Fn: dummyFileFn,
|
||||||
@@ -115,15 +113,15 @@ func TestProcessMainFilesInPlace(t *testing.T) {
|
|||||||
|
|
||||||
exit := p.main([]string{path1, path2}, os.Stdin, os.Stdout, os.Stderr)
|
exit := p.main([]string{path1, path2}, os.Stdin, os.Stdout, os.Stderr)
|
||||||
|
|
||||||
require.Equal(t, 0, exit)
|
assert.Equal(t, 0, exit)
|
||||||
|
|
||||||
v1, err := ioutil.ReadFile(path1)
|
v1, err := os.ReadFile(path1)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, "1", string(v1))
|
assert.Equal(t, "1", string(v1))
|
||||||
|
|
||||||
v2, err := ioutil.ReadFile(path2)
|
v2, err := os.ReadFile(path2)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, "2", string(v2))
|
assert.Equal(t, "2", string(v2))
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestProcessMainFilesInPlaceErrRead(t *testing.T) {
|
func TestProcessMainFilesInPlaceErrRead(t *testing.T) {
|
||||||
@@ -134,18 +132,18 @@ func TestProcessMainFilesInPlaceErrRead(t *testing.T) {
|
|||||||
|
|
||||||
exit := p.main([]string{"/this/path/is/invalid"}, os.Stdin, os.Stdout, os.Stderr)
|
exit := p.main([]string{"/this/path/is/invalid"}, os.Stdin, os.Stdout, os.Stderr)
|
||||||
|
|
||||||
require.Equal(t, -1, exit)
|
assert.Equal(t, -1, exit)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestProcessMainFilesInPlaceFailFn(t *testing.T) {
|
func TestProcessMainFilesInPlaceFailFn(t *testing.T) {
|
||||||
dir, err := ioutil.TempDir("", "")
|
dir, err := os.MkdirTemp("", "")
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
defer os.RemoveAll(dir)
|
defer os.RemoveAll(dir)
|
||||||
|
|
||||||
path1 := path.Join(dir, "file1")
|
path1 := path.Join(dir, "file1")
|
||||||
|
|
||||||
err = ioutil.WriteFile(path1, []byte("content 1"), 0600)
|
err = os.WriteFile(path1, []byte("content 1"), 0600)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
p := Program{
|
p := Program{
|
||||||
Fn: func(io.Reader, io.Writer) error { return fmt.Errorf("oh no") },
|
Fn: func(io.Reader, io.Writer) error { return fmt.Errorf("oh no") },
|
||||||
@@ -154,15 +152,15 @@ func TestProcessMainFilesInPlaceFailFn(t *testing.T) {
|
|||||||
|
|
||||||
exit := p.main([]string{path1}, os.Stdin, os.Stdout, os.Stderr)
|
exit := p.main([]string{path1}, os.Stdin, os.Stdout, os.Stderr)
|
||||||
|
|
||||||
require.Equal(t, -1, exit)
|
assert.Equal(t, -1, exit)
|
||||||
|
|
||||||
v1, err := ioutil.ReadFile(path1)
|
v1, err := os.ReadFile(path1)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, "content 1", string(v1))
|
assert.Equal(t, "content 1", string(v1))
|
||||||
}
|
}
|
||||||
|
|
||||||
func dummyFileFn(r io.Reader, w io.Writer) error {
|
func dummyFileFn(r io.Reader, w io.Writer) error {
|
||||||
b, err := ioutil.ReadAll(r)
|
b, err := io.ReadAll(r)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -4,9 +4,7 @@ import (
|
|||||||
"testing"
|
"testing"
|
||||||
"unsafe"
|
"unsafe"
|
||||||
|
|
||||||
"github.com/stretchr/testify/assert"
|
"github.com/pelletier/go-toml/v2/internal/assert"
|
||||||
"github.com/stretchr/testify/require"
|
|
||||||
|
|
||||||
"github.com/pelletier/go-toml/v2/internal/danger"
|
"github.com/pelletier/go-toml/v2/internal/danger"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -72,7 +70,7 @@ func TestSubsliceOffsetInvalid(t *testing.T) {
|
|||||||
for _, e := range examples {
|
for _, e := range examples {
|
||||||
t.Run(e.desc, func(t *testing.T) {
|
t.Run(e.desc, func(t *testing.T) {
|
||||||
d, s := e.test()
|
d, s := e.test()
|
||||||
require.Panics(t, func() {
|
assert.Panics(t, func() {
|
||||||
danger.SubsliceOffset(d, s)
|
danger.SubsliceOffset(d, s)
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
@@ -83,9 +81,9 @@ func TestStride(t *testing.T) {
|
|||||||
a := []byte{1, 2, 3, 4}
|
a := []byte{1, 2, 3, 4}
|
||||||
x := &a[1]
|
x := &a[1]
|
||||||
n := (*byte)(danger.Stride(unsafe.Pointer(x), unsafe.Sizeof(byte(0)), 1))
|
n := (*byte)(danger.Stride(unsafe.Pointer(x), unsafe.Sizeof(byte(0)), 1))
|
||||||
require.Equal(t, &a[2], n)
|
assert.Equal(t, &a[2], n)
|
||||||
n = (*byte)(danger.Stride(unsafe.Pointer(x), unsafe.Sizeof(byte(0)), -1))
|
n = (*byte)(danger.Stride(unsafe.Pointer(x), unsafe.Sizeof(byte(0)), -1))
|
||||||
require.Equal(t, &a[0], n)
|
assert.Equal(t, &a[0], n)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestBytesRange(t *testing.T) {
|
func TestBytesRange(t *testing.T) {
|
||||||
@@ -166,12 +164,12 @@ func TestBytesRange(t *testing.T) {
|
|||||||
t.Run(e.desc, func(t *testing.T) {
|
t.Run(e.desc, func(t *testing.T) {
|
||||||
start, end := e.test()
|
start, end := e.test()
|
||||||
if e.expected == nil {
|
if e.expected == nil {
|
||||||
require.Panics(t, func() {
|
assert.Panics(t, func() {
|
||||||
danger.BytesRange(start, end)
|
danger.BytesRange(start, end)
|
||||||
})
|
})
|
||||||
} else {
|
} else {
|
||||||
res := danger.BytesRange(start, end)
|
res := danger.BytesRange(start, end)
|
||||||
require.Equal(t, e.expected, res)
|
assert.Equal(t, e.expected, res)
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -9,7 +9,7 @@ import (
|
|||||||
"time"
|
"time"
|
||||||
|
|
||||||
"github.com/pelletier/go-toml/v2"
|
"github.com/pelletier/go-toml/v2"
|
||||||
"github.com/stretchr/testify/require"
|
"github.com/pelletier/go-toml/v2/internal/assert"
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestDocMarshal(t *testing.T) {
|
func TestDocMarshal(t *testing.T) {
|
||||||
@@ -107,13 +107,13 @@ name = 'List.Second'
|
|||||||
`
|
`
|
||||||
|
|
||||||
result, err := toml.Marshal(docData)
|
result, err := toml.Marshal(docData)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, marshalTestToml, string(result))
|
assert.Equal(t, marshalTestToml, string(result))
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestBasicMarshalQuotedKey(t *testing.T) {
|
func TestBasicMarshalQuotedKey(t *testing.T) {
|
||||||
result, err := toml.Marshal(quotedKeyMarshalTestData)
|
result, err := toml.Marshal(quotedKeyMarshalTestData)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
expected := `'Z.string-àéù' = 'Hello'
|
expected := `'Z.string-àéù' = 'Hello'
|
||||||
'Yfloat-𝟘' = 3.5
|
'Yfloat-𝟘' = 3.5
|
||||||
@@ -128,7 +128,7 @@ String2 = 'Two'
|
|||||||
String2 = 'Three'
|
String2 = 'Three'
|
||||||
`
|
`
|
||||||
|
|
||||||
require.Equal(t, string(expected), string(result))
|
assert.Equal(t, string(expected), string(result))
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -153,7 +153,7 @@ func TestEmptyMarshal(t *testing.T) {
|
|||||||
Map: map[string]string{},
|
Map: map[string]string{},
|
||||||
}
|
}
|
||||||
result, err := toml.Marshal(doc)
|
result, err := toml.Marshal(doc)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
expected := `title = 'Placeholder'
|
expected := `title = 'Placeholder'
|
||||||
bool = false
|
bool = false
|
||||||
@@ -164,7 +164,7 @@ stringlist = []
|
|||||||
[map]
|
[map]
|
||||||
`
|
`
|
||||||
|
|
||||||
require.Equal(t, string(expected), string(result))
|
assert.Equal(t, string(expected), string(result))
|
||||||
}
|
}
|
||||||
|
|
||||||
type textMarshaler struct {
|
type textMarshaler struct {
|
||||||
@@ -187,13 +187,13 @@ func TestTextMarshaler(t *testing.T) {
|
|||||||
t.Run("at root", func(t *testing.T) {
|
t.Run("at root", func(t *testing.T) {
|
||||||
_, err := toml.Marshal(m)
|
_, err := toml.Marshal(m)
|
||||||
// in v2 we do not allow TextMarshaler at root
|
// in v2 we do not allow TextMarshaler at root
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
})
|
})
|
||||||
|
|
||||||
t.Run("leaf", func(t *testing.T) {
|
t.Run("leaf", func(t *testing.T) {
|
||||||
res, err := toml.Marshal(wrap{m})
|
res, err := toml.Marshal(wrap{m})
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
require.Equal(t, "TM = 'Sally Fields'\n", string(res))
|
assert.Equal(t, "TM = 'Sally Fields'\n", string(res))
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -16,8 +16,7 @@ import (
|
|||||||
"time"
|
"time"
|
||||||
|
|
||||||
"github.com/pelletier/go-toml/v2"
|
"github.com/pelletier/go-toml/v2"
|
||||||
"github.com/stretchr/testify/assert"
|
"github.com/pelletier/go-toml/v2/internal/assert"
|
||||||
"github.com/stretchr/testify/require"
|
|
||||||
)
|
)
|
||||||
|
|
||||||
type basicMarshalTestStruct struct {
|
type basicMarshalTestStruct struct {
|
||||||
@@ -123,7 +122,7 @@ func TestInterface(t *testing.T) {
|
|||||||
var config Conf
|
var config Conf
|
||||||
config.Inter = &NestedStruct{}
|
config.Inter = &NestedStruct{}
|
||||||
err := toml.Unmarshal(doc, &config)
|
err := toml.Unmarshal(doc, &config)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
expected := Conf{
|
expected := Conf{
|
||||||
Name: "rui",
|
Name: "rui",
|
||||||
Age: 18,
|
Age: 18,
|
||||||
@@ -139,8 +138,8 @@ func TestInterface(t *testing.T) {
|
|||||||
func TestBasicUnmarshal(t *testing.T) {
|
func TestBasicUnmarshal(t *testing.T) {
|
||||||
result := basicMarshalTestStruct{}
|
result := basicMarshalTestStruct{}
|
||||||
err := toml.Unmarshal(basicTestToml, &result)
|
err := toml.Unmarshal(basicTestToml, &result)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, basicTestData, result)
|
assert.Equal(t, basicTestData, result)
|
||||||
}
|
}
|
||||||
|
|
||||||
type quotedKeyMarshalTestStruct struct {
|
type quotedKeyMarshalTestStruct struct {
|
||||||
@@ -300,7 +299,7 @@ func TestDocUnmarshal(t *testing.T) {
|
|||||||
result := testDoc{}
|
result := testDoc{}
|
||||||
err := toml.Unmarshal(marshalTestToml, &result)
|
err := toml.Unmarshal(marshalTestToml, &result)
|
||||||
expected := docData
|
expected := docData
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, expected, result)
|
assert.Equal(t, expected, result)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -340,7 +339,7 @@ shouldntBeHere = 2
|
|||||||
func TestUnexportedUnmarshal(t *testing.T) {
|
func TestUnexportedUnmarshal(t *testing.T) {
|
||||||
result := unexportedMarshalTestStruct{}
|
result := unexportedMarshalTestStruct{}
|
||||||
err := toml.Unmarshal(unexportedTestToml, &result)
|
err := toml.Unmarshal(unexportedTestToml, &result)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, unexportedTestData, result)
|
assert.Equal(t, unexportedTestData, result)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -456,7 +455,7 @@ func TestEmptytomlUnmarshal(t *testing.T) {
|
|||||||
|
|
||||||
result := emptyMarshalTestStruct{}
|
result := emptyMarshalTestStruct{}
|
||||||
err := toml.Unmarshal(emptyTestToml, &result)
|
err := toml.Unmarshal(emptyTestToml, &result)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, emptyTestData, result)
|
assert.Equal(t, emptyTestData, result)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -504,7 +503,7 @@ Str = "Hello"
|
|||||||
func TestPointerUnmarshal(t *testing.T) {
|
func TestPointerUnmarshal(t *testing.T) {
|
||||||
result := pointerMarshalTestStruct{}
|
result := pointerMarshalTestStruct{}
|
||||||
err := toml.Unmarshal(pointerTestToml, &result)
|
err := toml.Unmarshal(pointerTestToml, &result)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, pointerTestData, result)
|
assert.Equal(t, pointerTestData, result)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -540,7 +539,7 @@ StringPtr = [["Three", "Four"]]
|
|||||||
func TestNestedUnmarshal(t *testing.T) {
|
func TestNestedUnmarshal(t *testing.T) {
|
||||||
result := nestedMarshalTestStruct{}
|
result := nestedMarshalTestStruct{}
|
||||||
err := toml.Unmarshal(nestedTestToml, &result)
|
err := toml.Unmarshal(nestedTestToml, &result)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, nestedTestData, result)
|
assert.Equal(t, nestedTestData, result)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -834,7 +833,7 @@ func TestUnmarshalTabInStringAndQuotedKey(t *testing.T) {
|
|||||||
t.Run(test.desc, func(t *testing.T) {
|
t.Run(test.desc, func(t *testing.T) {
|
||||||
result := Test{}
|
result := Test{}
|
||||||
err := toml.Unmarshal(test.input, &result)
|
err := toml.Unmarshal(test.input, &result)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, test.expected, result)
|
assert.Equal(t, test.expected, result)
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
@@ -963,7 +962,7 @@ func TestUnmarshalTypeTableHeader(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
expected := map[header]map[string]int{
|
expected := map[header]map[string]int{
|
||||||
"test": map[string]int{"a": 1},
|
"test": {"a": 1},
|
||||||
}
|
}
|
||||||
|
|
||||||
if !reflect.DeepEqual(result, expected) {
|
if !reflect.DeepEqual(result, expected) {
|
||||||
@@ -1090,7 +1089,7 @@ func TestUnmarshalCheckConversionFloatInt(t *testing.T) {
|
|||||||
for _, test := range testCases {
|
for _, test := range testCases {
|
||||||
t.Run(test.desc, func(t *testing.T) {
|
t.Run(test.desc, func(t *testing.T) {
|
||||||
err := toml.Unmarshal([]byte(test.input), &conversionCheck{})
|
err := toml.Unmarshal([]byte(test.input), &conversionCheck{})
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1125,7 +1124,7 @@ func TestUnmarshalOverflow(t *testing.T) {
|
|||||||
for _, test := range testCases {
|
for _, test := range testCases {
|
||||||
t.Run(test.desc, func(t *testing.T) {
|
t.Run(test.desc, func(t *testing.T) {
|
||||||
err := toml.Unmarshal([]byte(test.input), &overflow{})
|
err := toml.Unmarshal([]byte(test.input), &overflow{})
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1745,7 +1744,7 @@ Age = 23
|
|||||||
}
|
}
|
||||||
actual := OuterStruct{}
|
actual := OuterStruct{}
|
||||||
err := toml.Unmarshal(doc, &actual)
|
err := toml.Unmarshal(doc, &actual)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, expected, actual)
|
assert.Equal(t, expected, actual)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1830,7 +1829,7 @@ InnerField = "After4"
|
|||||||
}
|
}
|
||||||
|
|
||||||
err := toml.Unmarshal(doc, &actual)
|
err := toml.Unmarshal(doc, &actual)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, expected, actual)
|
assert.Equal(t, expected, actual)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1879,7 +1878,7 @@ type arrayTooSmallStruct struct {
|
|||||||
func TestUnmarshalSlice(t *testing.T) {
|
func TestUnmarshalSlice(t *testing.T) {
|
||||||
var actual sliceStruct
|
var actual sliceStruct
|
||||||
err := toml.Unmarshal(sliceTomlDemo, &actual)
|
err := toml.Unmarshal(sliceTomlDemo, &actual)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
expected := sliceStruct{
|
expected := sliceStruct{
|
||||||
Slice: []string{"Howdy", "Hey There"},
|
Slice: []string{"Howdy", "Hey There"},
|
||||||
SlicePtr: &[]string{"Howdy", "Hey There"},
|
SlicePtr: &[]string{"Howdy", "Hey There"},
|
||||||
@@ -1930,7 +1929,7 @@ func TestUnmarshalMixedTypeSlice(t *testing.T) {
|
|||||||
},
|
},
|
||||||
}
|
}
|
||||||
err := toml.Unmarshal(doc, &actual)
|
err := toml.Unmarshal(doc, &actual)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, expected, actual)
|
assert.Equal(t, expected, actual)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1939,7 +1938,7 @@ func TestUnmarshalArray(t *testing.T) {
|
|||||||
|
|
||||||
var actual arrayStruct
|
var actual arrayStruct
|
||||||
err = toml.Unmarshal(sliceTomlDemo, &actual)
|
err = toml.Unmarshal(sliceTomlDemo, &actual)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
expected := arrayStruct{
|
expected := arrayStruct{
|
||||||
Slice: [4]string{"Howdy", "Hey There"},
|
Slice: [4]string{"Howdy", "Hey There"},
|
||||||
@@ -1998,8 +1997,13 @@ func TestDecoderStrict(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
err := strictDecoder(input).Decode(&doc)
|
err := strictDecoder(input).Decode(&doc)
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
require.IsType(t, &toml.StrictMissingError{}, err)
|
|
||||||
|
assert.Equal(t,
|
||||||
|
reflect.TypeOf(err), reflect.TypeOf(&toml.StrictMissingError{}),
|
||||||
|
"Expected a *toml.StrictMissingError, got: %v", reflect.TypeOf(err),
|
||||||
|
)
|
||||||
|
|
||||||
se := err.(*toml.StrictMissingError)
|
se := err.(*toml.StrictMissingError)
|
||||||
|
|
||||||
keys := []toml.Key{}
|
keys := []toml.Key{}
|
||||||
@@ -2015,10 +2019,10 @@ func TestDecoderStrict(t *testing.T) {
|
|||||||
{"undecoded", "array"},
|
{"undecoded", "array"},
|
||||||
}
|
}
|
||||||
|
|
||||||
require.Equal(t, expectedKeys, keys)
|
assert.Equal(t, expectedKeys, keys)
|
||||||
|
|
||||||
err = decoder(input).Decode(&doc)
|
err = decoder(input).Decode(&doc)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
var m map[string]interface{}
|
var m map[string]interface{}
|
||||||
err = decoder(input).Decode(&m)
|
err = decoder(input).Decode(&m)
|
||||||
@@ -2036,7 +2040,7 @@ func TestDecoderStrictValid(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
err := strictDecoder(input).Decode(&doc)
|
err := strictDecoder(input).Decode(&doc)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
}
|
}
|
||||||
|
|
||||||
type docUnmarshalTOML struct {
|
type docUnmarshalTOML struct {
|
||||||
@@ -2087,7 +2091,7 @@ func TestCustomUnmarshal(t *testing.T) {
|
|||||||
|
|
||||||
var d parent
|
var d parent
|
||||||
err := toml.Unmarshal([]byte(input), &d)
|
err := toml.Unmarshal([]byte(input), &d)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, "ok1", d.Doc.Decoded.Key)
|
assert.Equal(t, "ok1", d.Doc.Decoded.Key)
|
||||||
assert.Equal(t, "ok2", d.DocPointer.Decoded.Key)
|
assert.Equal(t, "ok2", d.DocPointer.Decoded.Key)
|
||||||
}
|
}
|
||||||
@@ -2153,7 +2157,7 @@ Int = 21
|
|||||||
Float = 2.0
|
Float = 2.0
|
||||||
`
|
`
|
||||||
err := toml.Unmarshal([]byte(input), &doc)
|
err := toml.Unmarshal([]byte(input), &doc)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, 12, doc.UnixTime.Value)
|
assert.Equal(t, 12, doc.UnixTime.Value)
|
||||||
assert.Equal(t, 42, doc.Version.Value)
|
assert.Equal(t, 42, doc.Version.Value)
|
||||||
assert.Equal(t, 1, doc.Bool.Value)
|
assert.Equal(t, 1, doc.Bool.Value)
|
||||||
@@ -2223,7 +2227,10 @@ func TestUnmarshalEmptyInterface(t *testing.T) {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatal(err)
|
t.Fatal(err)
|
||||||
}
|
}
|
||||||
require.IsType(t, map[string]interface{}{}, v)
|
assert.Equal(t,
|
||||||
|
reflect.TypeOf(map[string]interface{}{}), reflect.TypeOf(v),
|
||||||
|
"Expected map[string]interface{}{} type, got: %v", reflect.TypeOf(v),
|
||||||
|
)
|
||||||
|
|
||||||
x := v.(map[string]interface{})
|
x := v.(map[string]interface{})
|
||||||
assert.Equal(t, "pelletier", x["User"])
|
assert.Equal(t, "pelletier", x["User"])
|
||||||
@@ -2276,7 +2283,7 @@ func (c *Custom) UnmarshalTOML(v interface{}) error {
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestGithubIssue431(t *testing.T) {
|
func TestGitHubIssue431(t *testing.T) {
|
||||||
doc := `key = "value"`
|
doc := `key = "value"`
|
||||||
var c Config
|
var c Config
|
||||||
if err := toml.Unmarshal([]byte(doc), &c); err != nil {
|
if err := toml.Unmarshal([]byte(doc), &c); err != nil {
|
||||||
@@ -2314,7 +2321,7 @@ type config437 struct {
|
|||||||
} `toml:"HTTP"`
|
} `toml:"HTTP"`
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestGithubIssue437(t *testing.T) {
|
func TestGitHubIssue437(t *testing.T) {
|
||||||
t.Skipf("unmarshalTOML not implemented")
|
t.Skipf("unmarshalTOML not implemented")
|
||||||
src := `
|
src := `
|
||||||
[HTTP]
|
[HTTP]
|
||||||
|
|||||||
@@ -42,7 +42,7 @@ func rmTag(typedJson interface{}) (interface{}, error) {
|
|||||||
}
|
}
|
||||||
return m, nil
|
return m, nil
|
||||||
|
|
||||||
// Array: remove tags from all itenm.
|
// Array: remove tags from all items.
|
||||||
case []interface{}:
|
case []interface{}:
|
||||||
a := make([]interface{}, len(v))
|
a := make([]interface{}, len(v))
|
||||||
for i := range v {
|
for i := range v {
|
||||||
|
|||||||
@@ -10,7 +10,7 @@ import (
|
|||||||
"github.com/pelletier/go-toml/v2"
|
"github.com/pelletier/go-toml/v2"
|
||||||
)
|
)
|
||||||
|
|
||||||
// Marshal is a helpfer function for calling toml.Marshal
|
// Marshal is a helper function for calling toml.Marshal
|
||||||
//
|
//
|
||||||
// Only needed to avoid package import loops.
|
// Only needed to avoid package import loops.
|
||||||
func Marshal(v interface{}) ([]byte, error) {
|
func Marshal(v interface{}) ([]byte, error) {
|
||||||
|
|||||||
@@ -4,7 +4,7 @@ import (
|
|||||||
"testing"
|
"testing"
|
||||||
"unsafe"
|
"unsafe"
|
||||||
|
|
||||||
"github.com/stretchr/testify/require"
|
"github.com/pelletier/go-toml/v2/internal/assert"
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestEntrySize(t *testing.T) {
|
func TestEntrySize(t *testing.T) {
|
||||||
@@ -12,5 +12,9 @@ func TestEntrySize(t *testing.T) {
|
|||||||
// performance of unmarshaling documents. Should only be increased with care
|
// performance of unmarshaling documents. Should only be increased with care
|
||||||
// and a very good reason.
|
// and a very good reason.
|
||||||
maxExpectedEntrySize := 48
|
maxExpectedEntrySize := 48
|
||||||
require.LessOrEqual(t, int(unsafe.Sizeof(entry{})), maxExpectedEntrySize)
|
assert.True(t,
|
||||||
|
int(unsafe.Sizeof(entry{})) <= maxExpectedEntrySize,
|
||||||
|
"Expected entry to be less than or equal to %d, got: %d",
|
||||||
|
maxExpectedEntrySize, int(unsafe.Sizeof(entry{})),
|
||||||
|
)
|
||||||
}
|
}
|
||||||
|
|||||||
+7
-1
@@ -94,7 +94,13 @@ type LocalDateTime struct {
|
|||||||
|
|
||||||
// AsTime converts d into a specific time instance in zone.
|
// AsTime converts d into a specific time instance in zone.
|
||||||
func (d LocalDateTime) AsTime(zone *time.Location) time.Time {
|
func (d LocalDateTime) AsTime(zone *time.Location) time.Time {
|
||||||
return time.Date(d.Year, time.Month(d.Month), d.Day, d.Hour, d.Minute, d.Second, d.Nanosecond, zone)
|
// Normalize leap seconds (second=60) to second=59 to prevent overflow
|
||||||
|
// when Go's time.Date normalizes the time.
|
||||||
|
second := d.Second
|
||||||
|
if second == 60 {
|
||||||
|
second = 59
|
||||||
|
}
|
||||||
|
return time.Date(d.Year, time.Month(d.Month), d.Day, d.Hour, d.Minute, second, d.Nanosecond, zone)
|
||||||
}
|
}
|
||||||
|
|
||||||
// String returns RFC 3339 representation of d.
|
// String returns RFC 3339 representation of d.
|
||||||
|
|||||||
+28
-28
@@ -5,73 +5,73 @@ import (
|
|||||||
"time"
|
"time"
|
||||||
|
|
||||||
"github.com/pelletier/go-toml/v2"
|
"github.com/pelletier/go-toml/v2"
|
||||||
"github.com/stretchr/testify/require"
|
"github.com/pelletier/go-toml/v2/internal/assert"
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestLocalDate_AsTime(t *testing.T) {
|
func TestLocalDate_AsTime(t *testing.T) {
|
||||||
d := toml.LocalDate{2021, 6, 8}
|
d := toml.LocalDate{2021, 6, 8}
|
||||||
cast := d.AsTime(time.UTC)
|
cast := d.AsTime(time.UTC)
|
||||||
require.Equal(t, time.Date(2021, time.June, 8, 0, 0, 0, 0, time.UTC), cast)
|
assert.Equal(t, time.Date(2021, time.June, 8, 0, 0, 0, 0, time.UTC), cast)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestLocalDate_String(t *testing.T) {
|
func TestLocalDate_String(t *testing.T) {
|
||||||
d := toml.LocalDate{2021, 6, 8}
|
d := toml.LocalDate{2021, 6, 8}
|
||||||
require.Equal(t, "2021-06-08", d.String())
|
assert.Equal(t, "2021-06-08", d.String())
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestLocalDate_MarshalText(t *testing.T) {
|
func TestLocalDate_MarshalText(t *testing.T) {
|
||||||
d := toml.LocalDate{2021, 6, 8}
|
d := toml.LocalDate{2021, 6, 8}
|
||||||
b, err := d.MarshalText()
|
b, err := d.MarshalText()
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, []byte("2021-06-08"), b)
|
assert.Equal(t, []byte("2021-06-08"), b)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestLocalDate_UnmarshalMarshalText(t *testing.T) {
|
func TestLocalDate_UnmarshalMarshalText(t *testing.T) {
|
||||||
d := toml.LocalDate{}
|
d := toml.LocalDate{}
|
||||||
err := d.UnmarshalText([]byte("2021-06-08"))
|
err := d.UnmarshalText([]byte("2021-06-08"))
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, toml.LocalDate{2021, 6, 8}, d)
|
assert.Equal(t, toml.LocalDate{2021, 6, 8}, d)
|
||||||
|
|
||||||
err = d.UnmarshalText([]byte("what"))
|
err = d.UnmarshalText([]byte("what"))
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestLocalTime_String(t *testing.T) {
|
func TestLocalTime_String(t *testing.T) {
|
||||||
d := toml.LocalTime{20, 12, 1, 2, 9}
|
d := toml.LocalTime{20, 12, 1, 2, 9}
|
||||||
require.Equal(t, "20:12:01.000000002", d.String())
|
assert.Equal(t, "20:12:01.000000002", d.String())
|
||||||
d = toml.LocalTime{20, 12, 1, 0, 0}
|
d = toml.LocalTime{20, 12, 1, 0, 0}
|
||||||
require.Equal(t, "20:12:01", d.String())
|
assert.Equal(t, "20:12:01", d.String())
|
||||||
d = toml.LocalTime{20, 12, 1, 0, 9}
|
d = toml.LocalTime{20, 12, 1, 0, 9}
|
||||||
require.Equal(t, "20:12:01.000000000", d.String())
|
assert.Equal(t, "20:12:01.000000000", d.String())
|
||||||
d = toml.LocalTime{20, 12, 1, 100, 0}
|
d = toml.LocalTime{20, 12, 1, 100, 0}
|
||||||
require.Equal(t, "20:12:01.0000001", d.String())
|
assert.Equal(t, "20:12:01.0000001", d.String())
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestLocalTime_MarshalText(t *testing.T) {
|
func TestLocalTime_MarshalText(t *testing.T) {
|
||||||
d := toml.LocalTime{20, 12, 1, 2, 9}
|
d := toml.LocalTime{20, 12, 1, 2, 9}
|
||||||
b, err := d.MarshalText()
|
b, err := d.MarshalText()
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, []byte("20:12:01.000000002"), b)
|
assert.Equal(t, []byte("20:12:01.000000002"), b)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestLocalTime_UnmarshalMarshalText(t *testing.T) {
|
func TestLocalTime_UnmarshalMarshalText(t *testing.T) {
|
||||||
d := toml.LocalTime{}
|
d := toml.LocalTime{}
|
||||||
err := d.UnmarshalText([]byte("20:12:01.000000002"))
|
err := d.UnmarshalText([]byte("20:12:01.000000002"))
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, toml.LocalTime{20, 12, 1, 2, 9}, d)
|
assert.Equal(t, toml.LocalTime{20, 12, 1, 2, 9}, d)
|
||||||
|
|
||||||
err = d.UnmarshalText([]byte("what"))
|
err = d.UnmarshalText([]byte("what"))
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
|
|
||||||
err = d.UnmarshalText([]byte("20:12:01.000000002 bad"))
|
err = d.UnmarshalText([]byte("20:12:01.000000002 bad"))
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestLocalTime_RoundTrip(t *testing.T) {
|
func TestLocalTime_RoundTrip(t *testing.T) {
|
||||||
var d struct{ A toml.LocalTime }
|
var d struct{ A toml.LocalTime }
|
||||||
err := toml.Unmarshal([]byte("a=20:12:01.500"), &d)
|
err := toml.Unmarshal([]byte("a=20:12:01.500"), &d)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, "20:12:01.500", d.A.String())
|
assert.Equal(t, "20:12:01.500", d.A.String())
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestLocalDateTime_AsTime(t *testing.T) {
|
func TestLocalDateTime_AsTime(t *testing.T) {
|
||||||
@@ -80,7 +80,7 @@ func TestLocalDateTime_AsTime(t *testing.T) {
|
|||||||
toml.LocalTime{20, 12, 1, 2, 9},
|
toml.LocalTime{20, 12, 1, 2, 9},
|
||||||
}
|
}
|
||||||
cast := d.AsTime(time.UTC)
|
cast := d.AsTime(time.UTC)
|
||||||
require.Equal(t, time.Date(2021, time.June, 8, 20, 12, 1, 2, time.UTC), cast)
|
assert.Equal(t, time.Date(2021, time.June, 8, 20, 12, 1, 2, time.UTC), cast)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestLocalDateTime_String(t *testing.T) {
|
func TestLocalDateTime_String(t *testing.T) {
|
||||||
@@ -88,7 +88,7 @@ func TestLocalDateTime_String(t *testing.T) {
|
|||||||
toml.LocalDate{2021, 6, 8},
|
toml.LocalDate{2021, 6, 8},
|
||||||
toml.LocalTime{20, 12, 1, 2, 9},
|
toml.LocalTime{20, 12, 1, 2, 9},
|
||||||
}
|
}
|
||||||
require.Equal(t, "2021-06-08T20:12:01.000000002", d.String())
|
assert.Equal(t, "2021-06-08T20:12:01.000000002", d.String())
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestLocalDateTime_MarshalText(t *testing.T) {
|
func TestLocalDateTime_MarshalText(t *testing.T) {
|
||||||
@@ -97,22 +97,22 @@ func TestLocalDateTime_MarshalText(t *testing.T) {
|
|||||||
toml.LocalTime{20, 12, 1, 2, 9},
|
toml.LocalTime{20, 12, 1, 2, 9},
|
||||||
}
|
}
|
||||||
b, err := d.MarshalText()
|
b, err := d.MarshalText()
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, []byte("2021-06-08T20:12:01.000000002"), b)
|
assert.Equal(t, []byte("2021-06-08T20:12:01.000000002"), b)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestLocalDateTime_UnmarshalMarshalText(t *testing.T) {
|
func TestLocalDateTime_UnmarshalMarshalText(t *testing.T) {
|
||||||
d := toml.LocalDateTime{}
|
d := toml.LocalDateTime{}
|
||||||
err := d.UnmarshalText([]byte("2021-06-08 20:12:01.000000002"))
|
err := d.UnmarshalText([]byte("2021-06-08 20:12:01.000000002"))
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, toml.LocalDateTime{
|
assert.Equal(t, toml.LocalDateTime{
|
||||||
toml.LocalDate{2021, 6, 8},
|
toml.LocalDate{2021, 6, 8},
|
||||||
toml.LocalTime{20, 12, 1, 2, 9},
|
toml.LocalTime{20, 12, 1, 2, 9},
|
||||||
}, d)
|
}, d)
|
||||||
|
|
||||||
err = d.UnmarshalText([]byte("what"))
|
err = d.UnmarshalText([]byte("what"))
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
|
|
||||||
err = d.UnmarshalText([]byte("2021-06-08 20:12:01.000000002 bad"))
|
err = d.UnmarshalText([]byte("2021-06-08 20:12:01.000000002 bad"))
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
}
|
}
|
||||||
|
|||||||
+55
-9
@@ -8,7 +8,7 @@ import (
|
|||||||
"io"
|
"io"
|
||||||
"math"
|
"math"
|
||||||
"reflect"
|
"reflect"
|
||||||
"sort"
|
"slices"
|
||||||
"strconv"
|
"strconv"
|
||||||
"strings"
|
"strings"
|
||||||
"time"
|
"time"
|
||||||
@@ -161,6 +161,8 @@ func (enc *Encoder) SetMarshalJsonNumbers(indent bool) *Encoder {
|
|||||||
//
|
//
|
||||||
// The "omitempty" option prevents empty values or groups from being emitted.
|
// The "omitempty" option prevents empty values or groups from being emitted.
|
||||||
//
|
//
|
||||||
|
// The "omitzero" option prevents zero values or groups from being emitted.
|
||||||
|
//
|
||||||
// The "commented" option prefixes the value and all its children with a comment
|
// The "commented" option prefixes the value and all its children with a comment
|
||||||
// symbol.
|
// symbol.
|
||||||
//
|
//
|
||||||
@@ -196,6 +198,7 @@ func (enc *Encoder) Encode(v interface{}) error {
|
|||||||
type valueOptions struct {
|
type valueOptions struct {
|
||||||
multiline bool
|
multiline bool
|
||||||
omitempty bool
|
omitempty bool
|
||||||
|
omitzero bool
|
||||||
commented bool
|
commented bool
|
||||||
comment string
|
comment string
|
||||||
}
|
}
|
||||||
@@ -280,7 +283,7 @@ func (enc *Encoder) encode(b []byte, ctx encoderCtx, v reflect.Value) ([]byte, e
|
|||||||
}
|
}
|
||||||
|
|
||||||
hasTextMarshaler := v.Type().Implements(textMarshalerType)
|
hasTextMarshaler := v.Type().Implements(textMarshalerType)
|
||||||
if hasTextMarshaler || (v.CanAddr() && reflect.PtrTo(v.Type()).Implements(textMarshalerType)) {
|
if hasTextMarshaler || (v.CanAddr() && reflect.PointerTo(v.Type()).Implements(textMarshalerType)) {
|
||||||
if !hasTextMarshaler {
|
if !hasTextMarshaler {
|
||||||
v = v.Addr()
|
v = v.Addr()
|
||||||
}
|
}
|
||||||
@@ -384,6 +387,10 @@ func shouldOmitEmpty(options valueOptions, v reflect.Value) bool {
|
|||||||
return options.omitempty && isEmptyValue(v)
|
return options.omitempty && isEmptyValue(v)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func shouldOmitZero(options valueOptions, v reflect.Value) bool {
|
||||||
|
return options.omitzero && v.IsZero()
|
||||||
|
}
|
||||||
|
|
||||||
func (enc *Encoder) encodeKv(b []byte, ctx encoderCtx, options valueOptions, v reflect.Value) ([]byte, error) {
|
func (enc *Encoder) encodeKv(b []byte, ctx encoderCtx, options valueOptions, v reflect.Value) ([]byte, error) {
|
||||||
var err error
|
var err error
|
||||||
|
|
||||||
@@ -517,12 +524,26 @@ func (enc *Encoder) encodeQuotedString(multiline bool, b []byte, v string) []byt
|
|||||||
del = 0x7f
|
del = 0x7f
|
||||||
)
|
)
|
||||||
|
|
||||||
for _, r := range []byte(v) {
|
bv := []byte(v)
|
||||||
|
for i := 0; i < len(bv); i++ {
|
||||||
|
r := bv[i]
|
||||||
switch r {
|
switch r {
|
||||||
case '\\':
|
case '\\':
|
||||||
b = append(b, `\\`...)
|
b = append(b, `\\`...)
|
||||||
case '"':
|
case '"':
|
||||||
b = append(b, `\"`...)
|
if multiline {
|
||||||
|
// Quotation marks do not need to be quoted in multiline strings unless
|
||||||
|
// it contains 3 consecutive. If 3+ quotes appear, quote all of them
|
||||||
|
// because it's visually better
|
||||||
|
if i+2 > len(bv) || bv[i+1] != '"' || bv[i+2] != '"' {
|
||||||
|
b = append(b, r)
|
||||||
|
} else {
|
||||||
|
b = append(b, `\"\"\"`...)
|
||||||
|
i += 2
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
b = append(b, `\"`...)
|
||||||
|
}
|
||||||
case '\b':
|
case '\b':
|
||||||
b = append(b, `\b`...)
|
b = append(b, `\b`...)
|
||||||
case '\f':
|
case '\f':
|
||||||
@@ -631,6 +652,18 @@ func (enc *Encoder) keyToString(k reflect.Value) (string, error) {
|
|||||||
return "", fmt.Errorf("toml: error marshalling key %v from text: %w", k, err)
|
return "", fmt.Errorf("toml: error marshalling key %v from text: %w", k, err)
|
||||||
}
|
}
|
||||||
return string(keyB), nil
|
return string(keyB), nil
|
||||||
|
|
||||||
|
case keyType.Kind() == reflect.Int || keyType.Kind() == reflect.Int8 || keyType.Kind() == reflect.Int16 || keyType.Kind() == reflect.Int32 || keyType.Kind() == reflect.Int64:
|
||||||
|
return strconv.FormatInt(k.Int(), 10), nil
|
||||||
|
|
||||||
|
case keyType.Kind() == reflect.Uint || keyType.Kind() == reflect.Uint8 || keyType.Kind() == reflect.Uint16 || keyType.Kind() == reflect.Uint32 || keyType.Kind() == reflect.Uint64:
|
||||||
|
return strconv.FormatUint(k.Uint(), 10), nil
|
||||||
|
|
||||||
|
case keyType.Kind() == reflect.Float32:
|
||||||
|
return strconv.FormatFloat(k.Float(), 'f', -1, 32), nil
|
||||||
|
|
||||||
|
case keyType.Kind() == reflect.Float64:
|
||||||
|
return strconv.FormatFloat(k.Float(), 'f', -1, 64), nil
|
||||||
}
|
}
|
||||||
return "", fmt.Errorf("toml: type %s is not supported as a map key", keyType.Kind())
|
return "", fmt.Errorf("toml: type %s is not supported as a map key", keyType.Kind())
|
||||||
}
|
}
|
||||||
@@ -668,8 +701,8 @@ func (enc *Encoder) encodeMap(b []byte, ctx encoderCtx, v reflect.Value) ([]byte
|
|||||||
}
|
}
|
||||||
|
|
||||||
func sortEntriesByKey(e []entry) {
|
func sortEntriesByKey(e []entry) {
|
||||||
sort.Slice(e, func(i, j int) bool {
|
slices.SortFunc(e, func(a, b entry) int {
|
||||||
return e[i].Key < e[j].Key
|
return strings.Compare(a.Key, b.Key)
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -732,7 +765,7 @@ func walkStruct(ctx encoderCtx, t *table, v reflect.Value) {
|
|||||||
if fieldType.Anonymous {
|
if fieldType.Anonymous {
|
||||||
if fieldType.Type.Kind() == reflect.Struct {
|
if fieldType.Type.Kind() == reflect.Struct {
|
||||||
walkStruct(ctx, t, f)
|
walkStruct(ctx, t, f)
|
||||||
} else if fieldType.Type.Kind() == reflect.Pointer && !f.IsNil() && f.Elem().Kind() == reflect.Struct {
|
} else if fieldType.Type.Kind() == reflect.Ptr && !f.IsNil() && f.Elem().Kind() == reflect.Struct {
|
||||||
walkStruct(ctx, t, f.Elem())
|
walkStruct(ctx, t, f.Elem())
|
||||||
}
|
}
|
||||||
continue
|
continue
|
||||||
@@ -748,6 +781,7 @@ func walkStruct(ctx encoderCtx, t *table, v reflect.Value) {
|
|||||||
options := valueOptions{
|
options := valueOptions{
|
||||||
multiline: opts.multiline,
|
multiline: opts.multiline,
|
||||||
omitempty: opts.omitempty,
|
omitempty: opts.omitempty,
|
||||||
|
omitzero: opts.omitzero,
|
||||||
commented: opts.commented,
|
commented: opts.commented,
|
||||||
comment: fieldType.Tag.Get("comment"),
|
comment: fieldType.Tag.Get("comment"),
|
||||||
}
|
}
|
||||||
@@ -808,6 +842,7 @@ type tagOptions struct {
|
|||||||
multiline bool
|
multiline bool
|
||||||
inline bool
|
inline bool
|
||||||
omitempty bool
|
omitempty bool
|
||||||
|
omitzero bool
|
||||||
commented bool
|
commented bool
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -820,7 +855,7 @@ func parseTag(tag string) (string, tagOptions) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
raw := tag[idx+1:]
|
raw := tag[idx+1:]
|
||||||
tag = string(tag[:idx])
|
tag = tag[:idx]
|
||||||
for raw != "" {
|
for raw != "" {
|
||||||
var o string
|
var o string
|
||||||
i := strings.Index(raw, ",")
|
i := strings.Index(raw, ",")
|
||||||
@@ -836,6 +871,8 @@ func parseTag(tag string) (string, tagOptions) {
|
|||||||
opts.inline = true
|
opts.inline = true
|
||||||
case "omitempty":
|
case "omitempty":
|
||||||
opts.omitempty = true
|
opts.omitempty = true
|
||||||
|
case "omitzero":
|
||||||
|
opts.omitzero = true
|
||||||
case "commented":
|
case "commented":
|
||||||
opts.commented = true
|
opts.commented = true
|
||||||
}
|
}
|
||||||
@@ -870,6 +907,9 @@ func (enc *Encoder) encodeTable(b []byte, ctx encoderCtx, t table) ([]byte, erro
|
|||||||
if shouldOmitEmpty(kv.Options, kv.Value) {
|
if shouldOmitEmpty(kv.Options, kv.Value) {
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
if shouldOmitZero(kv.Options, kv.Value) {
|
||||||
|
continue
|
||||||
|
}
|
||||||
hasNonEmptyKV = true
|
hasNonEmptyKV = true
|
||||||
|
|
||||||
ctx.setKey(kv.Key)
|
ctx.setKey(kv.Key)
|
||||||
@@ -889,6 +929,9 @@ func (enc *Encoder) encodeTable(b []byte, ctx encoderCtx, t table) ([]byte, erro
|
|||||||
if shouldOmitEmpty(table.Options, table.Value) {
|
if shouldOmitEmpty(table.Options, table.Value) {
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
if shouldOmitZero(table.Options, table.Value) {
|
||||||
|
continue
|
||||||
|
}
|
||||||
if first {
|
if first {
|
||||||
first = false
|
first = false
|
||||||
if hasNonEmptyKV {
|
if hasNonEmptyKV {
|
||||||
@@ -923,6 +966,9 @@ func (enc *Encoder) encodeTableInline(b []byte, ctx encoderCtx, t table) ([]byte
|
|||||||
if shouldOmitEmpty(kv.Options, kv.Value) {
|
if shouldOmitEmpty(kv.Options, kv.Value) {
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
if shouldOmitZero(kv.Options, kv.Value) {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
|
||||||
if first {
|
if first {
|
||||||
first = false
|
first = false
|
||||||
@@ -951,7 +997,7 @@ func willConvertToTable(ctx encoderCtx, v reflect.Value) bool {
|
|||||||
if !v.IsValid() {
|
if !v.IsValid() {
|
||||||
return false
|
return false
|
||||||
}
|
}
|
||||||
if v.Type() == timeType || v.Type().Implements(textMarshalerType) || (v.Kind() != reflect.Ptr && v.CanAddr() && reflect.PtrTo(v.Type()).Implements(textMarshalerType)) {
|
if v.Type() == timeType || v.Type().Implements(textMarshalerType) || (v.Kind() != reflect.Ptr && v.CanAddr() && reflect.PointerTo(v.Type()).Implements(textMarshalerType)) {
|
||||||
return false
|
return false
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
+273
-79
@@ -6,13 +6,14 @@ import (
|
|||||||
"fmt"
|
"fmt"
|
||||||
"math"
|
"math"
|
||||||
"math/big"
|
"math/big"
|
||||||
|
"net/netip"
|
||||||
|
"reflect"
|
||||||
"strings"
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"github.com/pelletier/go-toml/v2"
|
"github.com/pelletier/go-toml/v2"
|
||||||
"github.com/stretchr/testify/assert"
|
"github.com/pelletier/go-toml/v2/internal/assert"
|
||||||
"github.com/stretchr/testify/require"
|
|
||||||
)
|
)
|
||||||
|
|
||||||
type marshalTextKey struct {
|
type marshalTextKey struct {
|
||||||
@@ -30,6 +31,27 @@ func (k marshalBadTextKey) MarshalText() ([]byte, error) {
|
|||||||
return nil, fmt.Errorf("error")
|
return nil, fmt.Errorf("error")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func toFloat(x interface{}) float64 {
|
||||||
|
// Shortened version of testify/toFloat
|
||||||
|
var xf float64
|
||||||
|
switch xn := x.(type) {
|
||||||
|
case float32:
|
||||||
|
xf = float64(xn)
|
||||||
|
case float64:
|
||||||
|
xf = xn
|
||||||
|
}
|
||||||
|
return xf
|
||||||
|
}
|
||||||
|
|
||||||
|
func inDelta(t *testing.T, expected, actual interface{}, delta float64) {
|
||||||
|
dt := toFloat(expected) - toFloat(actual)
|
||||||
|
assert.True(t,
|
||||||
|
dt < -delta && dt < delta,
|
||||||
|
"Difference between %v and %v is %v, but difference was %v",
|
||||||
|
expected, actual, delta, dt,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
func TestMarshal(t *testing.T) {
|
func TestMarshal(t *testing.T) {
|
||||||
someInt := 42
|
someInt := 42
|
||||||
|
|
||||||
@@ -366,6 +388,54 @@ name = 'Alice'
|
|||||||
expected: `A = """
|
expected: `A = """
|
||||||
hello
|
hello
|
||||||
world"""
|
world"""
|
||||||
|
`,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "multi-line quotation",
|
||||||
|
v: struct {
|
||||||
|
A string `toml:",multiline"`
|
||||||
|
}{
|
||||||
|
A: "hello\n\"world\"",
|
||||||
|
},
|
||||||
|
expected: `A = """
|
||||||
|
hello
|
||||||
|
"world""""
|
||||||
|
`,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "multi-line triple quotation",
|
||||||
|
v: struct {
|
||||||
|
A string `toml:",multiline"`
|
||||||
|
}{
|
||||||
|
A: "hello\n\"\"\"world\"",
|
||||||
|
},
|
||||||
|
expected: `A = """
|
||||||
|
hello
|
||||||
|
\"\"\"world""""
|
||||||
|
`,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "multi-line triple quotation",
|
||||||
|
v: struct {
|
||||||
|
A string `toml:",multiline"`
|
||||||
|
}{
|
||||||
|
A: "hello\n\"world\"\"\"",
|
||||||
|
},
|
||||||
|
expected: `A = """
|
||||||
|
hello
|
||||||
|
"world\"\"\""""
|
||||||
|
`,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "multi-line sextuple quotation",
|
||||||
|
v: struct {
|
||||||
|
A string `toml:",multiline"`
|
||||||
|
}{
|
||||||
|
A: "hello\n\"\"\"\"\"\"world\"",
|
||||||
|
},
|
||||||
|
expected: `A = """
|
||||||
|
hello
|
||||||
|
\"\"\"\"\"\"world""""
|
||||||
`,
|
`,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
@@ -587,13 +657,69 @@ foo = 42
|
|||||||
`,
|
`,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
desc: "invalid map key",
|
desc: "int map key",
|
||||||
v: map[int]interface{}{1: "a"},
|
v: map[int]interface{}{1: "a"},
|
||||||
|
expected: `1 = 'a'
|
||||||
|
`,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "int8 map key",
|
||||||
|
v: map[int8]interface{}{1: "a"},
|
||||||
|
expected: `1 = 'a'
|
||||||
|
`,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "int64 map key",
|
||||||
|
v: map[int64]interface{}{1: "a"},
|
||||||
|
expected: `1 = 'a'
|
||||||
|
`,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "uint map key",
|
||||||
|
v: map[uint]interface{}{1: "a"},
|
||||||
|
expected: `1 = 'a'
|
||||||
|
`,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "uint8 map key",
|
||||||
|
v: map[uint8]interface{}{1: "a"},
|
||||||
|
expected: `1 = 'a'
|
||||||
|
`,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "uint64 map key",
|
||||||
|
v: map[uint64]interface{}{1: "a"},
|
||||||
|
expected: `1 = 'a'
|
||||||
|
`,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "float32 map key",
|
||||||
|
v: map[float32]interface{}{
|
||||||
|
1.1: "a",
|
||||||
|
1.0020: "b",
|
||||||
|
},
|
||||||
|
expected: `'1.002' = 'b'
|
||||||
|
'1.1' = 'a'
|
||||||
|
`,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "float64 map key",
|
||||||
|
v: map[float64]interface{}{
|
||||||
|
1.1: "a",
|
||||||
|
1.0020: "b",
|
||||||
|
},
|
||||||
|
expected: `'1.002' = 'b'
|
||||||
|
'1.1' = 'a'
|
||||||
|
`,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
desc: "invalid map key",
|
||||||
|
v: map[struct{ int }]interface{}{{1}: "a"},
|
||||||
err: true,
|
err: true,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
desc: "invalid map key but empty",
|
desc: "invalid map key but empty",
|
||||||
v: map[int]interface{}{},
|
v: map[struct{ int }]interface{}{},
|
||||||
expected: "",
|
expected: "",
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
@@ -708,18 +834,18 @@ Three = [1, 2, 3]
|
|||||||
t.Run(e.desc, func(t *testing.T) {
|
t.Run(e.desc, func(t *testing.T) {
|
||||||
b, err := toml.Marshal(e.v)
|
b, err := toml.Marshal(e.v)
|
||||||
if e.err {
|
if e.err {
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
|
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, e.expected, string(b))
|
assert.Equal(t, e.expected, string(b))
|
||||||
|
|
||||||
// make sure the output is always valid TOML
|
// make sure the output is always valid TOML
|
||||||
defaultMap := map[string]interface{}{}
|
defaultMap := map[string]interface{}{}
|
||||||
err = toml.Unmarshal(b, &defaultMap)
|
err = toml.Unmarshal(b, &defaultMap)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
testWithAllFlags(t, func(t *testing.T, flags int) {
|
testWithAllFlags(t, func(t *testing.T, flags int) {
|
||||||
t.Helper()
|
t.Helper()
|
||||||
@@ -729,13 +855,13 @@ Three = [1, 2, 3]
|
|||||||
setFlags(enc, flags)
|
setFlags(enc, flags)
|
||||||
|
|
||||||
err := enc.Encode(e.v)
|
err := enc.Encode(e.v)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
inlineMap := map[string]interface{}{}
|
inlineMap := map[string]interface{}{}
|
||||||
err = toml.Unmarshal(buf.Bytes(), &inlineMap)
|
err = toml.Unmarshal(buf.Bytes(), &inlineMap)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
require.Equal(t, defaultMap, inlineMap)
|
assert.Equal(t, defaultMap, inlineMap)
|
||||||
})
|
})
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
@@ -802,8 +928,8 @@ nan = nan
|
|||||||
`
|
`
|
||||||
|
|
||||||
actual, err := toml.Marshal(v)
|
actual, err := toml.Marshal(v)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, expected, string(actual))
|
assert.Equal(t, expected, string(actual))
|
||||||
|
|
||||||
v64 := map[string]float64{
|
v64 := map[string]float64{
|
||||||
"nan": math.NaN(),
|
"nan": math.NaN(),
|
||||||
@@ -812,8 +938,8 @@ nan = nan
|
|||||||
}
|
}
|
||||||
|
|
||||||
actual, err = toml.Marshal(v64)
|
actual, err = toml.Marshal(v64)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, expected, string(actual))
|
assert.Equal(t, expected, string(actual))
|
||||||
}
|
}
|
||||||
|
|
||||||
//nolint:funlen
|
//nolint:funlen
|
||||||
@@ -873,7 +999,7 @@ func TestMarshalIndentTables(t *testing.T) {
|
|||||||
enc := toml.NewEncoder(&buf)
|
enc := toml.NewEncoder(&buf)
|
||||||
enc.SetIndentTables(true)
|
enc.SetIndentTables(true)
|
||||||
err := enc.Encode(e.v)
|
err := enc.Encode(e.v)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, e.expected, buf.String())
|
assert.Equal(t, e.expected, buf.String())
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
@@ -893,13 +1019,13 @@ func (c *customTextMarshaler) MarshalText() ([]byte, error) {
|
|||||||
func TestMarshalTextMarshaler_NoRoot(t *testing.T) {
|
func TestMarshalTextMarshaler_NoRoot(t *testing.T) {
|
||||||
c := customTextMarshaler{}
|
c := customTextMarshaler{}
|
||||||
_, err := toml.Marshal(&c)
|
_, err := toml.Marshal(&c)
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestMarshalTextMarshaler_Error(t *testing.T) {
|
func TestMarshalTextMarshaler_Error(t *testing.T) {
|
||||||
m := map[string]interface{}{"a": &customTextMarshaler{value: 1}}
|
m := map[string]interface{}{"a": &customTextMarshaler{value: 1}}
|
||||||
_, err := toml.Marshal(m)
|
_, err := toml.Marshal(m)
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestMarshalTextMarshaler_ErrorInline(t *testing.T) {
|
func TestMarshalTextMarshaler_ErrorInline(t *testing.T) {
|
||||||
@@ -912,13 +1038,13 @@ func TestMarshalTextMarshaler_ErrorInline(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
_, err := toml.Marshal(d)
|
_, err := toml.Marshal(d)
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestMarshalTextMarshaler(t *testing.T) {
|
func TestMarshalTextMarshaler(t *testing.T) {
|
||||||
m := map[string]interface{}{"a": &customTextMarshaler{value: 2}}
|
m := map[string]interface{}{"a": &customTextMarshaler{value: 2}}
|
||||||
r, err := toml.Marshal(m)
|
r, err := toml.Marshal(m)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, "a = '::2'\n", string(r))
|
assert.Equal(t, "a = '::2'\n", string(r))
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -932,7 +1058,7 @@ func TestEncodeToBrokenWriter(t *testing.T) {
|
|||||||
w := brokenWriter{}
|
w := brokenWriter{}
|
||||||
enc := toml.NewEncoder(&w)
|
enc := toml.NewEncoder(&w)
|
||||||
err := enc.Encode(map[string]string{"hello": "world"})
|
err := enc.Encode(map[string]string{"hello": "world"})
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestEncoderSetIndentSymbol(t *testing.T) {
|
func TestEncoderSetIndentSymbol(t *testing.T) {
|
||||||
@@ -941,7 +1067,7 @@ func TestEncoderSetIndentSymbol(t *testing.T) {
|
|||||||
enc.SetIndentTables(true)
|
enc.SetIndentTables(true)
|
||||||
enc.SetIndentSymbol(">>>")
|
enc.SetIndentSymbol(">>>")
|
||||||
err := enc.Encode(map[string]map[string]string{"parent": {"hello": "world"}})
|
err := enc.Encode(map[string]map[string]string{"parent": {"hello": "world"}})
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
expected := `[parent]
|
expected := `[parent]
|
||||||
>>>hello = 'world'
|
>>>hello = 'world'
|
||||||
`
|
`
|
||||||
@@ -960,7 +1086,7 @@ func TestEncoderSetMarshalJsonNumbers(t *testing.T) {
|
|||||||
"E": json.Number("0.0"),
|
"E": json.Number("0.0"),
|
||||||
"F": json.Number(""),
|
"F": json.Number(""),
|
||||||
})
|
})
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
expected := `A = 1.1
|
expected := `A = 1.1
|
||||||
B = 0.042
|
B = 0.042
|
||||||
C = 42
|
C = 42
|
||||||
@@ -992,14 +1118,78 @@ func TestEncoderOmitempty(t *testing.T) {
|
|||||||
Ptr *string `toml:",omitempty,multiline"`
|
Ptr *string `toml:",omitempty,multiline"`
|
||||||
Iface interface{} `toml:",omitempty,multiline"`
|
Iface interface{} `toml:",omitempty,multiline"`
|
||||||
Struct struct{} `toml:",omitempty,multiline"`
|
Struct struct{} `toml:",omitempty,multiline"`
|
||||||
|
Inline struct {
|
||||||
|
String string `toml:",omitempty,multiline"`
|
||||||
|
} `toml:",inline"`
|
||||||
}
|
}
|
||||||
|
|
||||||
d := doc{}
|
d := doc{}
|
||||||
|
|
||||||
b, err := toml.Marshal(d)
|
b, err := toml.Marshal(d)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
expected := ``
|
expected := `Inline = {}
|
||||||
|
`
|
||||||
|
|
||||||
|
assert.Equal(t, expected, string(b))
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestEncoderOmitzero(t *testing.T) {
|
||||||
|
type doc struct {
|
||||||
|
String string `toml:",omitzero,multiline"`
|
||||||
|
Bool bool `toml:",omitzero,multiline"`
|
||||||
|
Int int `toml:",omitzero,multiline"`
|
||||||
|
Int8 int8 `toml:",omitzero,multiline"`
|
||||||
|
Int16 int16 `toml:",omitzero,multiline"`
|
||||||
|
Int32 int32 `toml:",omitzero,multiline"`
|
||||||
|
Int64 int64 `toml:",omitzero,multiline"`
|
||||||
|
Uint uint `toml:",omitzero,multiline"`
|
||||||
|
Uint8 uint8 `toml:",omitzero,multiline"`
|
||||||
|
Uint16 uint16 `toml:",omitzero,multiline"`
|
||||||
|
Uint32 uint32 `toml:",omitzero,multiline"`
|
||||||
|
Uint64 uint64 `toml:",omitzero,multiline"`
|
||||||
|
Float32 float32 `toml:",omitzero,multiline"`
|
||||||
|
Float64 float64 `toml:",omitzero,multiline"`
|
||||||
|
MapNil map[string]string `toml:",omitzero,multiline"`
|
||||||
|
Slice []string `toml:",omitzero,multiline"`
|
||||||
|
Ptr *string `toml:",omitzero,multiline"`
|
||||||
|
Iface interface{} `toml:",omitzero,multiline"`
|
||||||
|
Struct struct{} `toml:",omitzero,multiline"`
|
||||||
|
Time time.Time `toml:",omitzero,multiline"`
|
||||||
|
IP netip.Addr `toml:",omitzero,multiline"`
|
||||||
|
Inline struct {
|
||||||
|
String string `toml:",omitzero,multiline"`
|
||||||
|
} `toml:",inline"`
|
||||||
|
}
|
||||||
|
|
||||||
|
d := doc{}
|
||||||
|
|
||||||
|
b, err := toml.Marshal(d)
|
||||||
|
assert.NoError(t, err)
|
||||||
|
|
||||||
|
expected := `Inline = {}
|
||||||
|
`
|
||||||
|
|
||||||
|
assert.Equal(t, expected, string(b))
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestEncoderOmitzeroOpaqueStruct(t *testing.T) {
|
||||||
|
type doc struct {
|
||||||
|
Time time.Time `toml:",omitzero"`
|
||||||
|
IP netip.Addr `toml:",omitzero"`
|
||||||
|
}
|
||||||
|
|
||||||
|
d := doc{
|
||||||
|
Time: time.Date(2001, 2, 3, 4, 5, 6, 7, time.UTC),
|
||||||
|
IP: netip.MustParseAddr("192.168.178.35"),
|
||||||
|
}
|
||||||
|
|
||||||
|
b, err := toml.Marshal(d)
|
||||||
|
assert.NoError(t, err)
|
||||||
|
|
||||||
|
expected := `Time = 2001-02-03T04:05:06.000000007Z
|
||||||
|
IP = '192.168.178.35'
|
||||||
|
`
|
||||||
|
|
||||||
assert.Equal(t, expected, string(b))
|
assert.Equal(t, expected, string(b))
|
||||||
}
|
}
|
||||||
@@ -1014,7 +1204,7 @@ func TestEncoderTagFieldName(t *testing.T) {
|
|||||||
d := doc{String: "world"}
|
d := doc{String: "world"}
|
||||||
|
|
||||||
b, err := toml.Marshal(d)
|
b, err := toml.Marshal(d)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
expected := `hello = 'world'
|
expected := `hello = 'world'
|
||||||
'#' = ''
|
'#' = ''
|
||||||
@@ -1029,11 +1219,11 @@ func TestIssue436(t *testing.T) {
|
|||||||
|
|
||||||
var v interface{}
|
var v interface{}
|
||||||
err := json.Unmarshal(data, &v)
|
err := json.Unmarshal(data, &v)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
var buf bytes.Buffer
|
var buf bytes.Buffer
|
||||||
err = toml.NewEncoder(&buf).Encode(v)
|
err = toml.NewEncoder(&buf).Encode(v)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
expected := `[[a]]
|
expected := `[[a]]
|
||||||
[a.b]
|
[a.b]
|
||||||
@@ -1055,27 +1245,30 @@ func TestIssue424(t *testing.T) {
|
|||||||
msg2 := Message2{"Hello\\World"}
|
msg2 := Message2{"Hello\\World"}
|
||||||
|
|
||||||
toml1, err := toml.Marshal(msg1)
|
toml1, err := toml.Marshal(msg1)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
toml2, err := toml.Marshal(msg2)
|
toml2, err := toml.Marshal(msg2)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
msg1parsed := Message1{}
|
msg1parsed := Message1{}
|
||||||
err = toml.Unmarshal(toml1, &msg1parsed)
|
err = toml.Unmarshal(toml1, &msg1parsed)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, msg1, msg1parsed)
|
assert.Equal(t, msg1, msg1parsed)
|
||||||
|
|
||||||
msg2parsed := Message2{}
|
msg2parsed := Message2{}
|
||||||
err = toml.Unmarshal(toml2, &msg2parsed)
|
err = toml.Unmarshal(toml2, &msg2parsed)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, msg2, msg2parsed)
|
assert.Equal(t, msg2, msg2parsed)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestIssue567(t *testing.T) {
|
func TestIssue567(t *testing.T) {
|
||||||
var m map[string]interface{}
|
var m map[string]interface{}
|
||||||
err := toml.Unmarshal([]byte("A = 12:08:05"), &m)
|
err := toml.Unmarshal([]byte("A = 12:08:05"), &m)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.IsType(t, m["A"], toml.LocalTime{})
|
assert.Equal(t,
|
||||||
|
reflect.TypeOf(m["A"]), reflect.TypeOf(toml.LocalTime{}),
|
||||||
|
"Expected type '%v', got: %v", reflect.TypeOf(m["A"]), reflect.TypeOf(toml.LocalTime{}),
|
||||||
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestIssue590(t *testing.T) {
|
func TestIssue590(t *testing.T) {
|
||||||
@@ -1084,7 +1277,7 @@ func TestIssue590(t *testing.T) {
|
|||||||
Option CustomType `toml:"option"`
|
Option CustomType `toml:"option"`
|
||||||
}
|
}
|
||||||
err := toml.Unmarshal([]byte("option = 42"), &cfg)
|
err := toml.Unmarshal([]byte("option = 42"), &cfg)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestIssue571(t *testing.T) {
|
func TestIssue571(t *testing.T) {
|
||||||
@@ -1100,14 +1293,14 @@ func TestIssue571(t *testing.T) {
|
|||||||
Float64: 43,
|
Float64: 43,
|
||||||
}
|
}
|
||||||
b, err := toml.Marshal(foo)
|
b, err := toml.Marshal(foo)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
var foo2 Foo
|
var foo2 Foo
|
||||||
err = toml.Unmarshal(b, &foo2)
|
err = toml.Unmarshal(b, &foo2)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
assert.InDelta(t, 42, foo2.Float32, closeEnough)
|
inDelta(t, 42, foo2.Float32, closeEnough)
|
||||||
assert.InDelta(t, 43, foo2.Float64, closeEnough)
|
inDelta(t, 43, foo2.Float64, closeEnough)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestIssue678(t *testing.T) {
|
func TestIssue678(t *testing.T) {
|
||||||
@@ -1120,13 +1313,13 @@ func TestIssue678(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
out, err := toml.Marshal(cfg)
|
out, err := toml.Marshal(cfg)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, "BigInt = '123'\n", string(out))
|
assert.Equal(t, "BigInt = '123'\n", string(out))
|
||||||
|
|
||||||
cfg2 := &Config{}
|
cfg2 := &Config{}
|
||||||
err = toml.Unmarshal(out, cfg2)
|
err = toml.Unmarshal(out, cfg2)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, cfg, cfg2)
|
assert.Equal(t, cfg, cfg2)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestIssue752(t *testing.T) {
|
func TestIssue752(t *testing.T) {
|
||||||
@@ -1141,8 +1334,8 @@ func TestIssue752(t *testing.T) {
|
|||||||
c := Container{}
|
c := Container{}
|
||||||
|
|
||||||
out, err := toml.Marshal(c)
|
out, err := toml.Marshal(c)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, "", string(out))
|
assert.Equal(t, "", string(out))
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestIssue768(t *testing.T) {
|
func TestIssue768(t *testing.T) {
|
||||||
@@ -1151,14 +1344,14 @@ func TestIssue768(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
out, err := toml.Marshal(&cfg{})
|
out, err := toml.Marshal(&cfg{})
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
expected := `# This is a multiline comment.
|
expected := `# This is a multiline comment.
|
||||||
# This is line 2.
|
# This is line 2.
|
||||||
Name = ''
|
Name = ''
|
||||||
`
|
`
|
||||||
|
|
||||||
require.Equal(t, expected, string(out))
|
assert.Equal(t, expected, string(out))
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestIssue786(t *testing.T) {
|
func TestIssue786(t *testing.T) {
|
||||||
@@ -1174,9 +1367,9 @@ func TestIssue786(t *testing.T) {
|
|||||||
|
|
||||||
x := Test{}
|
x := Test{}
|
||||||
b, err := toml.Marshal(x)
|
b, err := toml.Marshal(x)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
require.Equal(t, "", string(b))
|
assert.Equal(t, "", string(b))
|
||||||
|
|
||||||
type General struct {
|
type General struct {
|
||||||
From string `toml:"from,omitempty" json:"from,omitempty" comment:"from in graphite-web format, the local TZ is used"`
|
From string `toml:"from,omitempty" json:"from,omitempty" comment:"from in graphite-web format, the local TZ is used"`
|
||||||
@@ -1198,7 +1391,8 @@ func TestIssue786(t *testing.T) {
|
|||||||
config.Custom = []Custom{{Name: "omit", General: General{Randomize: false}}}
|
config.Custom = []Custom{{Name: "omit", General: General{Randomize: false}}}
|
||||||
config.Custom = append(config.Custom, Custom{Name: "present", General: General{From: "-2d", Randomize: true}})
|
config.Custom = append(config.Custom, Custom{Name: "present", General: General{From: "-2d", Randomize: true}})
|
||||||
encoder := toml.NewEncoder(buf)
|
encoder := toml.NewEncoder(buf)
|
||||||
encoder.Encode(config)
|
err = encoder.Encode(config)
|
||||||
|
assert.NoError(t, err)
|
||||||
|
|
||||||
expected := `# from in graphite-web format, the local TZ is used
|
expected := `# from in graphite-web format, the local TZ is used
|
||||||
from = '-2d'
|
from = '-2d'
|
||||||
@@ -1221,10 +1415,10 @@ from = '-2d'
|
|||||||
randomize = true
|
randomize = true
|
||||||
`
|
`
|
||||||
|
|
||||||
require.Equal(t, expected, buf.String())
|
assert.Equal(t, expected, buf.String())
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestMarhsalIssue888(t *testing.T) {
|
func TestMarshalIssue888(t *testing.T) {
|
||||||
type Thing struct {
|
type Thing struct {
|
||||||
FieldA string `comment:"my field A"`
|
FieldA string `comment:"my field A"`
|
||||||
FieldB string `comment:"my field B"`
|
FieldB string `comment:"my field B"`
|
||||||
@@ -1244,7 +1438,8 @@ func TestMarhsalIssue888(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
encoder := toml.NewEncoder(buf).SetIndentTables(true)
|
encoder := toml.NewEncoder(buf).SetIndentTables(true)
|
||||||
encoder.Encode(config)
|
err := encoder.Encode(config)
|
||||||
|
assert.NoError(t, err)
|
||||||
|
|
||||||
expected := `# custom config
|
expected := `# custom config
|
||||||
[[Custom]]
|
[[Custom]]
|
||||||
@@ -1260,7 +1455,7 @@ func TestMarhsalIssue888(t *testing.T) {
|
|||||||
FieldB = 'field b 2'
|
FieldB = 'field b 2'
|
||||||
`
|
`
|
||||||
|
|
||||||
require.Equal(t, expected, buf.String())
|
assert.Equal(t, expected, buf.String())
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestMarshalNestedAnonymousStructs(t *testing.T) {
|
func TestMarshalNestedAnonymousStructs(t *testing.T) {
|
||||||
@@ -1296,8 +1491,8 @@ value = ''
|
|||||||
`
|
`
|
||||||
|
|
||||||
result, err := toml.Marshal(doc)
|
result, err := toml.Marshal(doc)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, expected, string(result))
|
assert.Equal(t, expected, string(result))
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestMarshalNestedAnonymousStructs_DuplicateField(t *testing.T) {
|
func TestMarshalNestedAnonymousStructs_DuplicateField(t *testing.T) {
|
||||||
@@ -1322,9 +1517,9 @@ value = ''
|
|||||||
`
|
`
|
||||||
|
|
||||||
result, err := toml.Marshal(doc)
|
result, err := toml.Marshal(doc)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, expected, string(result))
|
assert.Equal(t, expected, string(result))
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestMarshalNestedAnonymousStructs_PointerEmbedded(t *testing.T) {
|
func TestMarshalNestedAnonymousStructs_PointerEmbedded(t *testing.T) {
|
||||||
@@ -1355,8 +1550,8 @@ func TestMarshalNestedAnonymousStructs_PointerEmbedded(t *testing.T) {
|
|||||||
`
|
`
|
||||||
|
|
||||||
result, err := toml.Marshal(doc)
|
result, err := toml.Marshal(doc)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, expected, string(result))
|
assert.Equal(t, expected, string(result))
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestLocalTime(t *testing.T) {
|
func TestLocalTime(t *testing.T) {
|
||||||
@@ -1373,12 +1568,12 @@ func TestLocalTime(t *testing.T) {
|
|||||||
`
|
`
|
||||||
|
|
||||||
out, err := toml.Marshal(v)
|
out, err := toml.Marshal(v)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
require.Equal(t, expected, string(out))
|
assert.Equal(t, expected, string(out))
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestMarshalUint64Overflow(t *testing.T) {
|
func TestMarshalUint64Overflow(t *testing.T) {
|
||||||
// The TOML spec only requires implementation to provide support for the
|
// The TOML spec only asserts implementation to provide support for the
|
||||||
// int64 range. To avoid generating TOML documents that would not be
|
// int64 range. To avoid generating TOML documents that would not be
|
||||||
// supported by standard-compliant parsers, uint64 > max int64 cannot be
|
// supported by standard-compliant parsers, uint64 > max int64 cannot be
|
||||||
// marshaled.
|
// marshaled.
|
||||||
@@ -1387,7 +1582,7 @@ func TestMarshalUint64Overflow(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
_, err := toml.Marshal(x)
|
_, err := toml.Marshal(x)
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestIndentWithInlineTable(t *testing.T) {
|
func TestIndentWithInlineTable(t *testing.T) {
|
||||||
@@ -1407,7 +1602,7 @@ func TestIndentWithInlineTable(t *testing.T) {
|
|||||||
enc.SetIndentTables(true)
|
enc.SetIndentTables(true)
|
||||||
enc.SetTablesInline(true)
|
enc.SetTablesInline(true)
|
||||||
enc.SetArraysMultiline(true)
|
enc.SetArraysMultiline(true)
|
||||||
require.NoError(t, enc.Encode(x))
|
assert.NoError(t, enc.Encode(x))
|
||||||
assert.Equal(t, expected, buf.String())
|
assert.Equal(t, expected, buf.String())
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1464,7 +1659,7 @@ func TestMarshalCommented(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
out, err := toml.Marshal(c)
|
out, err := toml.Marshal(c)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
expected := `# Int = 42
|
expected := `# Int = 42
|
||||||
# String = 'root'
|
# String = 'root'
|
||||||
@@ -1496,7 +1691,7 @@ func TestMarshalCommented(t *testing.T) {
|
|||||||
# Values = [4, 5, 6]
|
# Values = [4, 5, 6]
|
||||||
`
|
`
|
||||||
|
|
||||||
require.Equal(t, expected, string(out))
|
assert.Equal(t, expected, string(out))
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestMarshalIndentedCustomTypeArray(t *testing.T) {
|
func TestMarshalIndentedCustomTypeArray(t *testing.T) {
|
||||||
@@ -1532,8 +1727,8 @@ func TestMarshalIndentedCustomTypeArray(t *testing.T) {
|
|||||||
var buf bytes.Buffer
|
var buf bytes.Buffer
|
||||||
enc := toml.NewEncoder(&buf)
|
enc := toml.NewEncoder(&buf)
|
||||||
enc.SetIndentTables(true)
|
enc.SetIndentTables(true)
|
||||||
require.NoError(t, enc.Encode(c))
|
assert.NoError(t, enc.Encode(c))
|
||||||
require.Equal(t, expected, buf.String())
|
assert.Equal(t, expected, buf.String())
|
||||||
}
|
}
|
||||||
|
|
||||||
func ExampleMarshal() {
|
func ExampleMarshal() {
|
||||||
@@ -1565,7 +1760,6 @@ func ExampleMarshal() {
|
|||||||
// configuration file that has commented out sections (example from
|
// configuration file that has commented out sections (example from
|
||||||
// go-graphite/graphite-clickhouse).
|
// go-graphite/graphite-clickhouse).
|
||||||
func ExampleMarshal_commented() {
|
func ExampleMarshal_commented() {
|
||||||
|
|
||||||
type Common struct {
|
type Common struct {
|
||||||
Listen string `toml:"listen" comment:"general listener"`
|
Listen string `toml:"listen" comment:"general listener"`
|
||||||
PprofListen string `toml:"pprof-listen" comment:"listener to serve /debug/pprof requests. '-pprof' argument overrides it"`
|
PprofListen string `toml:"pprof-listen" comment:"listener to serve /debug/pprof requests. '-pprof' argument overrides it"`
|
||||||
@@ -1574,15 +1768,15 @@ func ExampleMarshal_commented() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
type Costs struct {
|
type Costs struct {
|
||||||
Cost *int `toml:"cost" comment:"default cost (for wildcarded equalence or matched with regex, or if no value cost set)"`
|
Cost *int `toml:"cost" comment:"default cost (for wildcarded equivalence or matched with regex, or if no value cost set)"`
|
||||||
ValuesCost map[string]int `toml:"values-cost" comment:"cost with some value (for equalence without wildcards) (additional tuning, usually not needed)"`
|
ValuesCost map[string]int `toml:"values-cost" comment:"cost with some value (for equivalence without wildcards) (additional tuning, usually not needed)"`
|
||||||
}
|
}
|
||||||
|
|
||||||
type ClickHouse struct {
|
type ClickHouse struct {
|
||||||
URL string `toml:"url" comment:"default url, see https://clickhouse.tech/docs/en/interfaces/http. Can be overwritten with query-params"`
|
URL string `toml:"url" comment:"default url, see https://clickhouse.tech/docs/en/interfaces/http. Can be overwritten with query-params"`
|
||||||
|
|
||||||
RenderMaxQueries int `toml:"render-max-queries" comment:"Max queries to render queiries"`
|
RenderMaxQueries int `toml:"render-max-queries" comment:"Max queries to render queries"`
|
||||||
RenderConcurrentQueries int `toml:"render-concurrent-queries" comment:"Concurrent queries to render queiries"`
|
RenderConcurrentQueries int `toml:"render-concurrent-queries" comment:"Concurrent queries to render queries"`
|
||||||
TaggedCosts map[string]*Costs `toml:"tagged-costs,commented"`
|
TaggedCosts map[string]*Costs `toml:"tagged-costs,commented"`
|
||||||
TreeTable string `toml:"tree-table,commented"`
|
TreeTable string `toml:"tree-table,commented"`
|
||||||
ReverseTreeTable string `toml:"reverse-tree-table,commented"`
|
ReverseTreeTable string `toml:"reverse-tree-table,commented"`
|
||||||
@@ -1656,9 +1850,9 @@ func ExampleMarshal_commented() {
|
|||||||
// [clickhouse]
|
// [clickhouse]
|
||||||
// # default url, see https://clickhouse.tech/docs/en/interfaces/http. Can be overwritten with query-params
|
// # default url, see https://clickhouse.tech/docs/en/interfaces/http. Can be overwritten with query-params
|
||||||
// url = 'http://localhost:8123?cancel_http_readonly_queries_on_client_close=1'
|
// url = 'http://localhost:8123?cancel_http_readonly_queries_on_client_close=1'
|
||||||
// # Max queries to render queiries
|
// # Max queries to render queries
|
||||||
// render-max-queries = 0
|
// render-max-queries = 0
|
||||||
// # Concurrent queries to render queiries
|
// # Concurrent queries to render queries
|
||||||
// render-concurrent-queries = 0
|
// render-concurrent-queries = 0
|
||||||
// # tree-table = ''
|
// # tree-table = ''
|
||||||
// # reverse-tree-table = ''
|
// # reverse-tree-table = ''
|
||||||
@@ -1704,7 +1898,7 @@ func TestReadmeComments(t *testing.T) {
|
|||||||
},
|
},
|
||||||
}
|
}
|
||||||
out, err := toml.Marshal(example)
|
out, err := toml.Marshal(example)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
expected := `# Host IP to connect to.
|
expected := `# Host IP to connect to.
|
||||||
host = '127.0.0.1'
|
host = '127.0.0.1'
|
||||||
@@ -1716,5 +1910,5 @@ port = 4242
|
|||||||
# cipher = 'AEAD-AES128-GCM-SHA256'
|
# cipher = 'AEAD-AES128-GCM-SHA256'
|
||||||
# version = 'TLS 1.3'
|
# version = 'TLS 1.3'
|
||||||
`
|
`
|
||||||
require.Equal(t, expected, string(out))
|
assert.Equal(t, expected, string(out))
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,6 +1,3 @@
|
|||||||
//go:build go1.18 || go1.19 || go1.20 || go1.21 || go1.22
|
|
||||||
// +build go1.18 go1.19 go1.20 go1.21 go1.22
|
|
||||||
|
|
||||||
package ossfuzz
|
package ossfuzz
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
|||||||
Executable
+596
@@ -0,0 +1,596 @@
|
|||||||
|
#!/usr/bin/env bash
|
||||||
|
|
||||||
|
set -uo pipefail
|
||||||
|
|
||||||
|
# Colors for output
|
||||||
|
RED='\033[0;31m'
|
||||||
|
GREEN='\033[0;32m'
|
||||||
|
YELLOW='\033[1;33m'
|
||||||
|
BLUE='\033[0;34m'
|
||||||
|
NC='\033[0m' # No Color
|
||||||
|
|
||||||
|
# Go versions to test (1.11 through 1.25)
|
||||||
|
GO_VERSIONS=(
|
||||||
|
"1.11"
|
||||||
|
"1.12"
|
||||||
|
"1.13"
|
||||||
|
"1.14"
|
||||||
|
"1.15"
|
||||||
|
"1.16"
|
||||||
|
"1.17"
|
||||||
|
"1.18"
|
||||||
|
"1.19"
|
||||||
|
"1.20"
|
||||||
|
"1.21"
|
||||||
|
"1.22"
|
||||||
|
"1.23"
|
||||||
|
"1.24"
|
||||||
|
"1.25"
|
||||||
|
)
|
||||||
|
|
||||||
|
# Default values
|
||||||
|
PARALLEL=true
|
||||||
|
VERBOSE=false
|
||||||
|
OUTPUT_DIR="test-results"
|
||||||
|
DOCKER_TIMEOUT="10m"
|
||||||
|
|
||||||
|
usage() {
|
||||||
|
cat << EOF
|
||||||
|
Usage: $0 [OPTIONS] [GO_VERSIONS...]
|
||||||
|
|
||||||
|
Test go-toml across multiple Go versions using Docker containers.
|
||||||
|
|
||||||
|
The script reports the lowest continuous supported Go version (where all subsequent
|
||||||
|
versions pass) and only exits with non-zero status if either of the two most recent
|
||||||
|
Go versions fail, indicating immediate attention is needed.
|
||||||
|
|
||||||
|
Note: For Go versions < 1.21, the script automatically updates go.mod to match the
|
||||||
|
target version, but older versions may still fail due to missing standard library
|
||||||
|
features (e.g., the 'slices' package introduced in Go 1.21).
|
||||||
|
|
||||||
|
OPTIONS:
|
||||||
|
-h, --help Show this help message
|
||||||
|
-s, --sequential Run tests sequentially instead of in parallel
|
||||||
|
-v, --verbose Enable verbose output
|
||||||
|
-o, --output DIR Output directory for test results (default: test-results)
|
||||||
|
-t, --timeout TIME Docker timeout for each test (default: 10m)
|
||||||
|
--list List available Go versions and exit
|
||||||
|
|
||||||
|
ARGUMENTS:
|
||||||
|
GO_VERSIONS Specific Go versions to test (default: all supported versions)
|
||||||
|
Examples: 1.21 1.22 1.23
|
||||||
|
|
||||||
|
EXAMPLES:
|
||||||
|
$0 # Test all Go versions in parallel
|
||||||
|
$0 --sequential # Test all Go versions sequentially
|
||||||
|
$0 1.21 1.22 1.23 # Test specific versions
|
||||||
|
$0 --verbose --output ./results 1.24 1.25 # Verbose output to custom directory
|
||||||
|
|
||||||
|
EXIT CODES:
|
||||||
|
0 Recent Go versions pass (good compatibility)
|
||||||
|
1 Recent Go versions fail (needs attention) or script error
|
||||||
|
|
||||||
|
EOF
|
||||||
|
}
|
||||||
|
|
||||||
|
log() {
|
||||||
|
echo -e "${BLUE}[$(date +'%H:%M:%S')]${NC} $*" >&2
|
||||||
|
}
|
||||||
|
|
||||||
|
log_success() {
|
||||||
|
echo -e "${GREEN}[$(date +'%H:%M:%S')] ✓${NC} $*" >&2
|
||||||
|
}
|
||||||
|
|
||||||
|
log_error() {
|
||||||
|
echo -e "${RED}[$(date +'%H:%M:%S')] ✗${NC} $*" >&2
|
||||||
|
}
|
||||||
|
|
||||||
|
log_warning() {
|
||||||
|
echo -e "${YELLOW}[$(date +'%H:%M:%S')] ⚠${NC} $*" >&2
|
||||||
|
}
|
||||||
|
|
||||||
|
# Parse command line arguments
|
||||||
|
while [[ $# -gt 0 ]]; do
|
||||||
|
case $1 in
|
||||||
|
-h|--help)
|
||||||
|
usage
|
||||||
|
exit 0
|
||||||
|
;;
|
||||||
|
-s|--sequential)
|
||||||
|
PARALLEL=false
|
||||||
|
shift
|
||||||
|
;;
|
||||||
|
-v|--verbose)
|
||||||
|
VERBOSE=true
|
||||||
|
shift
|
||||||
|
;;
|
||||||
|
-o|--output)
|
||||||
|
OUTPUT_DIR="$2"
|
||||||
|
shift 2
|
||||||
|
;;
|
||||||
|
-t|--timeout)
|
||||||
|
DOCKER_TIMEOUT="$2"
|
||||||
|
shift 2
|
||||||
|
;;
|
||||||
|
--list)
|
||||||
|
echo "Available Go versions:"
|
||||||
|
printf '%s\n' "${GO_VERSIONS[@]}"
|
||||||
|
exit 0
|
||||||
|
;;
|
||||||
|
-*)
|
||||||
|
echo "Unknown option: $1" >&2
|
||||||
|
usage
|
||||||
|
exit 1
|
||||||
|
;;
|
||||||
|
*)
|
||||||
|
# Remaining arguments are Go versions
|
||||||
|
break
|
||||||
|
;;
|
||||||
|
esac
|
||||||
|
done
|
||||||
|
|
||||||
|
# If specific versions provided, use those instead of defaults
|
||||||
|
if [[ $# -gt 0 ]]; then
|
||||||
|
GO_VERSIONS=("$@")
|
||||||
|
fi
|
||||||
|
|
||||||
|
# Validate Go versions
|
||||||
|
for version in "${GO_VERSIONS[@]}"; do
|
||||||
|
if ! [[ "$version" =~ ^1\.(1[1-9]|2[0-5])$ ]]; then
|
||||||
|
log_error "Invalid Go version: $version. Supported versions: 1.11-1.25"
|
||||||
|
exit 1
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
|
||||||
|
# Check if Docker is available
|
||||||
|
if ! command -v docker &> /dev/null; then
|
||||||
|
log_error "Docker is required but not installed or not in PATH"
|
||||||
|
exit 1
|
||||||
|
fi
|
||||||
|
|
||||||
|
# Check if Docker daemon is running
|
||||||
|
if ! docker info &> /dev/null; then
|
||||||
|
log_error "Docker daemon is not running"
|
||||||
|
exit 1
|
||||||
|
fi
|
||||||
|
|
||||||
|
# Create output directory
|
||||||
|
mkdir -p "$OUTPUT_DIR"
|
||||||
|
|
||||||
|
# Function to test a single Go version
|
||||||
|
test_go_version() {
|
||||||
|
local go_version="$1"
|
||||||
|
local container_name="go-toml-test-${go_version}"
|
||||||
|
local result_file="${OUTPUT_DIR}/go-${go_version}.txt"
|
||||||
|
local dockerfile_content
|
||||||
|
|
||||||
|
log "Testing Go $go_version..."
|
||||||
|
|
||||||
|
# Create a temporary Dockerfile for this version
|
||||||
|
# For Go versions < 1.21, we need to update go.mod to match the Go version
|
||||||
|
local needs_go_mod_update=false
|
||||||
|
if [[ $(echo "$go_version 1.21" | tr ' ' '\n' | sort -V | head -n1) == "$go_version" && "$go_version" != "1.21" ]]; then
|
||||||
|
needs_go_mod_update=true
|
||||||
|
fi
|
||||||
|
|
||||||
|
dockerfile_content="FROM golang:${go_version}-alpine
|
||||||
|
|
||||||
|
# Install git (required for go mod)
|
||||||
|
RUN apk add --no-cache git
|
||||||
|
|
||||||
|
# Set working directory
|
||||||
|
WORKDIR /app
|
||||||
|
|
||||||
|
# Copy source code
|
||||||
|
COPY . ."
|
||||||
|
|
||||||
|
# Add go.mod update step for older Go versions
|
||||||
|
if [[ "$needs_go_mod_update" == true ]]; then
|
||||||
|
dockerfile_content="$dockerfile_content
|
||||||
|
|
||||||
|
# Update go.mod to match Go version (required for Go < 1.21)
|
||||||
|
RUN if [ -f go.mod ]; then sed -i 's/^go [0-9]\\+\\.[0-9]\\+\\(\\.[0-9]\\+\\)\\?/go $go_version/' go.mod; fi
|
||||||
|
|
||||||
|
# Note: Go versions < 1.21 may fail due to missing standard library packages (e.g., slices)
|
||||||
|
# This is expected for projects that use Go 1.21+ features"
|
||||||
|
fi
|
||||||
|
|
||||||
|
dockerfile_content="$dockerfile_content
|
||||||
|
|
||||||
|
# Run tests
|
||||||
|
CMD [\"sh\", \"-c\", \"go version && echo '--- Running go test ./... ---' && go test ./...\"]"
|
||||||
|
|
||||||
|
# Create temporary directory for this test
|
||||||
|
local temp_dir
|
||||||
|
temp_dir=$(mktemp -d)
|
||||||
|
|
||||||
|
# Copy source to temp directory (excluding test results and git)
|
||||||
|
rsync -a --exclude="$OUTPUT_DIR" --exclude=".git" --exclude="*.test" . "$temp_dir/"
|
||||||
|
|
||||||
|
# Create Dockerfile in temp directory
|
||||||
|
echo "$dockerfile_content" > "$temp_dir/Dockerfile"
|
||||||
|
|
||||||
|
# Build and run container
|
||||||
|
local exit_code=0
|
||||||
|
local output
|
||||||
|
|
||||||
|
if $VERBOSE; then
|
||||||
|
log "Building Docker image for Go $go_version..."
|
||||||
|
fi
|
||||||
|
|
||||||
|
# Capture both stdout and stderr, and the exit code
|
||||||
|
if output=$(cd "$temp_dir" && timeout "$DOCKER_TIMEOUT" docker build -t "$container_name" . 2>&1 && \
|
||||||
|
timeout "$DOCKER_TIMEOUT" docker run --rm "$container_name" 2>&1); then
|
||||||
|
log_success "Go $go_version: PASSED"
|
||||||
|
echo "PASSED" > "${result_file}.status"
|
||||||
|
else
|
||||||
|
exit_code=$?
|
||||||
|
log_error "Go $go_version: FAILED (exit code: $exit_code)"
|
||||||
|
echo "FAILED" > "${result_file}.status"
|
||||||
|
fi
|
||||||
|
|
||||||
|
# Save full output
|
||||||
|
echo "$output" > "$result_file"
|
||||||
|
|
||||||
|
# Clean up
|
||||||
|
docker rmi "$container_name" &> /dev/null || true
|
||||||
|
rm -rf "$temp_dir"
|
||||||
|
|
||||||
|
if $VERBOSE; then
|
||||||
|
echo "--- Go $go_version output ---"
|
||||||
|
echo "$output"
|
||||||
|
echo "--- End Go $go_version output ---"
|
||||||
|
fi
|
||||||
|
|
||||||
|
return $exit_code
|
||||||
|
}
|
||||||
|
|
||||||
|
# Function to run tests in parallel
|
||||||
|
run_parallel() {
|
||||||
|
local pids=()
|
||||||
|
local failed_versions=()
|
||||||
|
|
||||||
|
log "Starting parallel tests for ${#GO_VERSIONS[@]} Go versions..."
|
||||||
|
|
||||||
|
# Start all tests in background
|
||||||
|
for version in "${GO_VERSIONS[@]}"; do
|
||||||
|
test_go_version "$version" &
|
||||||
|
pids+=($!)
|
||||||
|
done
|
||||||
|
|
||||||
|
# Wait for all tests to complete
|
||||||
|
for i in "${!pids[@]}"; do
|
||||||
|
local pid=${pids[$i]}
|
||||||
|
local version=${GO_VERSIONS[$i]}
|
||||||
|
|
||||||
|
if ! wait $pid; then
|
||||||
|
failed_versions+=("$version")
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
|
||||||
|
return ${#failed_versions[@]}
|
||||||
|
}
|
||||||
|
|
||||||
|
# Function to run tests sequentially
|
||||||
|
run_sequential() {
|
||||||
|
local failed_versions=()
|
||||||
|
|
||||||
|
log "Starting sequential tests for ${#GO_VERSIONS[@]} Go versions..."
|
||||||
|
|
||||||
|
for version in "${GO_VERSIONS[@]}"; do
|
||||||
|
if ! test_go_version "$version"; then
|
||||||
|
failed_versions+=("$version")
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
|
||||||
|
return ${#failed_versions[@]}
|
||||||
|
}
|
||||||
|
|
||||||
|
# Main execution
|
||||||
|
main() {
|
||||||
|
local start_time
|
||||||
|
start_time=$(date +%s)
|
||||||
|
|
||||||
|
log "Starting Go version compatibility tests..."
|
||||||
|
log "Testing versions: ${GO_VERSIONS[*]}"
|
||||||
|
log "Output directory: $OUTPUT_DIR"
|
||||||
|
log "Parallel execution: $PARALLEL"
|
||||||
|
|
||||||
|
local failed_count
|
||||||
|
if $PARALLEL; then
|
||||||
|
run_parallel
|
||||||
|
failed_count=$?
|
||||||
|
else
|
||||||
|
run_sequential
|
||||||
|
failed_count=$?
|
||||||
|
fi
|
||||||
|
|
||||||
|
local end_time
|
||||||
|
end_time=$(date +%s)
|
||||||
|
local duration=$((end_time - start_time))
|
||||||
|
|
||||||
|
# Collect results for display
|
||||||
|
local passed_versions=()
|
||||||
|
local failed_versions=()
|
||||||
|
local unknown_versions=()
|
||||||
|
local passed_count=0
|
||||||
|
|
||||||
|
for version in "${GO_VERSIONS[@]}"; do
|
||||||
|
local status_file="${OUTPUT_DIR}/go-${version}.txt.status"
|
||||||
|
if [[ -f "$status_file" ]]; then
|
||||||
|
local status
|
||||||
|
status=$(cat "$status_file")
|
||||||
|
if [[ "$status" == "PASSED" ]]; then
|
||||||
|
passed_versions+=("$version")
|
||||||
|
((passed_count++))
|
||||||
|
else
|
||||||
|
failed_versions+=("$version")
|
||||||
|
fi
|
||||||
|
else
|
||||||
|
unknown_versions+=("$version")
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
|
||||||
|
# Generate summary report
|
||||||
|
local summary_file="${OUTPUT_DIR}/summary.txt"
|
||||||
|
{
|
||||||
|
echo "Go Version Compatibility Test Summary"
|
||||||
|
echo "====================================="
|
||||||
|
echo "Date: $(date)"
|
||||||
|
echo "Duration: ${duration}s"
|
||||||
|
echo "Parallel: $PARALLEL"
|
||||||
|
echo ""
|
||||||
|
echo "Results:"
|
||||||
|
|
||||||
|
for version in "${GO_VERSIONS[@]}"; do
|
||||||
|
local status_file="${OUTPUT_DIR}/go-${version}.txt.status"
|
||||||
|
if [[ -f "$status_file" ]]; then
|
||||||
|
local status
|
||||||
|
status=$(cat "$status_file")
|
||||||
|
if [[ "$status" == "PASSED" ]]; then
|
||||||
|
echo " Go $version: ✓ PASSED"
|
||||||
|
else
|
||||||
|
echo " Go $version: ✗ FAILED"
|
||||||
|
fi
|
||||||
|
else
|
||||||
|
echo " Go $version: ? UNKNOWN (no status file)"
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
|
||||||
|
echo ""
|
||||||
|
echo "Summary: $passed_count/${#GO_VERSIONS[@]} versions passed"
|
||||||
|
|
||||||
|
if [[ $failed_count -gt 0 ]]; then
|
||||||
|
echo ""
|
||||||
|
echo "Failed versions details:"
|
||||||
|
for version in "${failed_versions[@]}"; do
|
||||||
|
echo ""
|
||||||
|
echo "--- Go $version (FAILED) ---"
|
||||||
|
local result_file="${OUTPUT_DIR}/go-${version}.txt"
|
||||||
|
if [[ -f "$result_file" ]]; then
|
||||||
|
tail -n 30 "$result_file"
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
fi
|
||||||
|
} > "$summary_file"
|
||||||
|
|
||||||
|
# Find lowest continuous supported version and check recent versions
|
||||||
|
local lowest_continuous_version=""
|
||||||
|
local recent_versions_failed=false
|
||||||
|
|
||||||
|
# Sort versions to ensure proper order
|
||||||
|
local sorted_versions=()
|
||||||
|
for version in "${GO_VERSIONS[@]}"; do
|
||||||
|
sorted_versions+=("$version")
|
||||||
|
done
|
||||||
|
# Sort versions numerically (1.11, 1.12, ..., 1.25)
|
||||||
|
IFS=$'\n' sorted_versions=($(sort -V <<< "${sorted_versions[*]}"))
|
||||||
|
|
||||||
|
# Find lowest continuous supported version (all versions from this point onwards pass)
|
||||||
|
for version in "${sorted_versions[@]}"; do
|
||||||
|
local status_file="${OUTPUT_DIR}/go-${version}.txt.status"
|
||||||
|
local all_subsequent_pass=true
|
||||||
|
|
||||||
|
# Check if this version and all subsequent versions pass
|
||||||
|
local found_current=false
|
||||||
|
for check_version in "${sorted_versions[@]}"; do
|
||||||
|
if [[ "$check_version" == "$version" ]]; then
|
||||||
|
found_current=true
|
||||||
|
fi
|
||||||
|
|
||||||
|
if [[ "$found_current" == true ]]; then
|
||||||
|
local check_status_file="${OUTPUT_DIR}/go-${check_version}.txt.status"
|
||||||
|
if [[ -f "$check_status_file" ]]; then
|
||||||
|
local status
|
||||||
|
status=$(cat "$check_status_file")
|
||||||
|
if [[ "$status" != "PASSED" ]]; then
|
||||||
|
all_subsequent_pass=false
|
||||||
|
break
|
||||||
|
fi
|
||||||
|
else
|
||||||
|
all_subsequent_pass=false
|
||||||
|
break
|
||||||
|
fi
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
|
||||||
|
if [[ "$all_subsequent_pass" == true ]]; then
|
||||||
|
lowest_continuous_version="$version"
|
||||||
|
break
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
|
||||||
|
# Check if the two most recent versions failed
|
||||||
|
local num_versions=${#sorted_versions[@]}
|
||||||
|
if [[ $num_versions -ge 2 ]]; then
|
||||||
|
local second_recent="${sorted_versions[$((num_versions-2))]}"
|
||||||
|
local most_recent="${sorted_versions[$((num_versions-1))]}"
|
||||||
|
|
||||||
|
local second_recent_status_file="${OUTPUT_DIR}/go-${second_recent}.txt.status"
|
||||||
|
local most_recent_status_file="${OUTPUT_DIR}/go-${most_recent}.txt.status"
|
||||||
|
|
||||||
|
local second_recent_failed=false
|
||||||
|
local most_recent_failed=false
|
||||||
|
|
||||||
|
if [[ -f "$second_recent_status_file" ]]; then
|
||||||
|
local status
|
||||||
|
status=$(cat "$second_recent_status_file")
|
||||||
|
if [[ "$status" != "PASSED" ]]; then
|
||||||
|
second_recent_failed=true
|
||||||
|
fi
|
||||||
|
else
|
||||||
|
second_recent_failed=true
|
||||||
|
fi
|
||||||
|
|
||||||
|
if [[ -f "$most_recent_status_file" ]]; then
|
||||||
|
local status
|
||||||
|
status=$(cat "$most_recent_status_file")
|
||||||
|
if [[ "$status" != "PASSED" ]]; then
|
||||||
|
most_recent_failed=true
|
||||||
|
fi
|
||||||
|
else
|
||||||
|
most_recent_failed=true
|
||||||
|
fi
|
||||||
|
|
||||||
|
if [[ "$second_recent_failed" == true || "$most_recent_failed" == true ]]; then
|
||||||
|
recent_versions_failed=true
|
||||||
|
fi
|
||||||
|
elif [[ $num_versions -eq 1 ]]; then
|
||||||
|
# Only one version tested, check if it's the most recent and failed
|
||||||
|
local only_version="${sorted_versions[0]}"
|
||||||
|
local only_status_file="${OUTPUT_DIR}/go-${only_version}.txt.status"
|
||||||
|
|
||||||
|
if [[ -f "$only_status_file" ]]; then
|
||||||
|
local status
|
||||||
|
status=$(cat "$only_status_file")
|
||||||
|
if [[ "$status" != "PASSED" ]]; then
|
||||||
|
recent_versions_failed=true
|
||||||
|
fi
|
||||||
|
else
|
||||||
|
recent_versions_failed=true
|
||||||
|
fi
|
||||||
|
fi
|
||||||
|
|
||||||
|
# Display summary
|
||||||
|
echo ""
|
||||||
|
log "Test completed in ${duration}s"
|
||||||
|
log "Summary report: $summary_file"
|
||||||
|
|
||||||
|
echo ""
|
||||||
|
echo "========================================"
|
||||||
|
echo " FINAL RESULTS"
|
||||||
|
echo "========================================"
|
||||||
|
echo ""
|
||||||
|
|
||||||
|
# Display passed versions
|
||||||
|
if [[ ${#passed_versions[@]} -gt 0 ]]; then
|
||||||
|
log_success "PASSED (${#passed_versions[@]}/${#GO_VERSIONS[@]}):"
|
||||||
|
# Sort passed versions for display
|
||||||
|
local sorted_passed=()
|
||||||
|
for version in "${sorted_versions[@]}"; do
|
||||||
|
for passed_version in "${passed_versions[@]}"; do
|
||||||
|
if [[ "$version" == "$passed_version" ]]; then
|
||||||
|
sorted_passed+=("$version")
|
||||||
|
break
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
done
|
||||||
|
for version in "${sorted_passed[@]}"; do
|
||||||
|
echo -e " ${GREEN}✓${NC} Go $version"
|
||||||
|
done
|
||||||
|
echo ""
|
||||||
|
fi
|
||||||
|
|
||||||
|
# Display failed versions
|
||||||
|
if [[ ${#failed_versions[@]} -gt 0 ]]; then
|
||||||
|
log_error "FAILED (${#failed_versions[@]}/${#GO_VERSIONS[@]}):"
|
||||||
|
# Sort failed versions for display
|
||||||
|
local sorted_failed=()
|
||||||
|
for version in "${sorted_versions[@]}"; do
|
||||||
|
for failed_version in "${failed_versions[@]}"; do
|
||||||
|
if [[ "$version" == "$failed_version" ]]; then
|
||||||
|
sorted_failed+=("$version")
|
||||||
|
break
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
done
|
||||||
|
for version in "${sorted_failed[@]}"; do
|
||||||
|
echo -e " ${RED}✗${NC} Go $version"
|
||||||
|
done
|
||||||
|
echo ""
|
||||||
|
|
||||||
|
# Show failure details
|
||||||
|
echo "========================================"
|
||||||
|
echo " FAILURE DETAILS"
|
||||||
|
echo "========================================"
|
||||||
|
echo ""
|
||||||
|
|
||||||
|
for version in "${sorted_failed[@]}"; do
|
||||||
|
echo -e "${RED}--- Go $version FAILURE LOGS (last 30 lines) ---${NC}"
|
||||||
|
local result_file="${OUTPUT_DIR}/go-${version}.txt"
|
||||||
|
if [[ -f "$result_file" ]]; then
|
||||||
|
tail -n 30 "$result_file" | sed 's/^/ /'
|
||||||
|
else
|
||||||
|
echo " No log file found: $result_file"
|
||||||
|
fi
|
||||||
|
echo ""
|
||||||
|
done
|
||||||
|
fi
|
||||||
|
|
||||||
|
# Display unknown versions
|
||||||
|
if [[ ${#unknown_versions[@]} -gt 0 ]]; then
|
||||||
|
log_warning "UNKNOWN (${#unknown_versions[@]}/${#GO_VERSIONS[@]}):"
|
||||||
|
for version in "${unknown_versions[@]}"; do
|
||||||
|
echo -e " ${YELLOW}?${NC} Go $version (no status file)"
|
||||||
|
done
|
||||||
|
echo ""
|
||||||
|
fi
|
||||||
|
|
||||||
|
echo "========================================"
|
||||||
|
echo " COMPATIBILITY SUMMARY"
|
||||||
|
echo "========================================"
|
||||||
|
echo ""
|
||||||
|
|
||||||
|
if [[ -n "$lowest_continuous_version" ]]; then
|
||||||
|
log_success "Lowest continuous supported version: Go $lowest_continuous_version"
|
||||||
|
echo " (All versions from Go $lowest_continuous_version onwards pass)"
|
||||||
|
else
|
||||||
|
log_error "No continuous version support found"
|
||||||
|
echo " (No version has all subsequent versions passing)"
|
||||||
|
fi
|
||||||
|
|
||||||
|
echo ""
|
||||||
|
echo "========================================"
|
||||||
|
echo "Full detailed logs available in: $OUTPUT_DIR"
|
||||||
|
echo "========================================"
|
||||||
|
|
||||||
|
# Determine exit code based on recent versions
|
||||||
|
if [[ "$recent_versions_failed" == true ]]; then
|
||||||
|
log_error "OVERALL RESULT: Recent Go versions failed - this needs attention!"
|
||||||
|
if [[ -n "$lowest_continuous_version" ]]; then
|
||||||
|
echo "Note: Continuous support starts from Go $lowest_continuous_version"
|
||||||
|
fi
|
||||||
|
exit 1
|
||||||
|
else
|
||||||
|
log_success "OVERALL RESULT: Recent Go versions pass - compatibility looks good!"
|
||||||
|
if [[ -n "$lowest_continuous_version" ]]; then
|
||||||
|
echo "Continuous support starts from Go $lowest_continuous_version"
|
||||||
|
fi
|
||||||
|
exit 0
|
||||||
|
fi
|
||||||
|
}
|
||||||
|
|
||||||
|
# Trap to clean up on exit
|
||||||
|
cleanup() {
|
||||||
|
# Kill any remaining background processes
|
||||||
|
jobs -p | xargs -r kill 2>/dev/null || true
|
||||||
|
|
||||||
|
# Clean up any remaining Docker containers
|
||||||
|
docker ps -q --filter "name=go-toml-test-" | xargs -r docker stop 2>/dev/null || true
|
||||||
|
docker images -q --filter "reference=go-toml-test-*" | xargs -r docker rmi 2>/dev/null || true
|
||||||
|
}
|
||||||
|
|
||||||
|
trap cleanup EXIT
|
||||||
|
|
||||||
|
# Run main function
|
||||||
|
main
|
||||||
@@ -1,5 +1,5 @@
|
|||||||
//go:generate go run github.com/toml-lang/toml-test/cmd/toml-test@master -copy ./tests
|
//go:generate go run github.com/toml-lang/toml-test/cmd/toml-test@v1.6.0 -copy ./tests
|
||||||
//go:generate go run ./cmd/tomltestgen/main.go -o toml_testgen_test.go
|
//go:generate go run ./cmd/tomltestgen/main.go -r v1.6.0 -o toml_testgen_test.go
|
||||||
|
|
||||||
// This is a support file for toml_testgen_test.go
|
// This is a support file for toml_testgen_test.go
|
||||||
package toml_test
|
package toml_test
|
||||||
@@ -9,8 +9,8 @@ import (
|
|||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
"github.com/pelletier/go-toml/v2"
|
"github.com/pelletier/go-toml/v2"
|
||||||
|
"github.com/pelletier/go-toml/v2/internal/assert"
|
||||||
"github.com/pelletier/go-toml/v2/internal/testsuite"
|
"github.com/pelletier/go-toml/v2/internal/testsuite"
|
||||||
"github.com/stretchr/testify/require"
|
|
||||||
)
|
)
|
||||||
|
|
||||||
func testgenInvalid(t *testing.T, input string) {
|
func testgenInvalid(t *testing.T, input string) {
|
||||||
@@ -45,15 +45,15 @@ func testgenValid(t *testing.T, input string, jsonRef string) {
|
|||||||
t.Fatalf("failed parsing toml: %s", err)
|
t.Fatalf("failed parsing toml: %s", err)
|
||||||
}
|
}
|
||||||
j, err := testsuite.ValueToTaggedJSON(doc)
|
j, err := testsuite.ValueToTaggedJSON(doc)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
var ref interface{}
|
var ref interface{}
|
||||||
err = json.Unmarshal([]byte(jsonRef), &ref)
|
err = json.Unmarshal([]byte(jsonRef), &ref)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
var actual interface{}
|
var actual interface{}
|
||||||
err = json.Unmarshal([]byte(j), &actual)
|
err = json.Unmarshal(j, &actual)
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
testsuite.CmpJSON(t, "", ref, actual)
|
testsuite.CmpJSON(t, "", ref, actual)
|
||||||
}
|
}
|
||||||
|
|||||||
+381
-193
File diff suppressed because it is too large
Load Diff
+74
-16
@@ -5,9 +5,9 @@ import (
|
|||||||
"errors"
|
"errors"
|
||||||
"fmt"
|
"fmt"
|
||||||
"io"
|
"io"
|
||||||
"io/ioutil"
|
|
||||||
"math"
|
"math"
|
||||||
"reflect"
|
"reflect"
|
||||||
|
"strconv"
|
||||||
"strings"
|
"strings"
|
||||||
"sync/atomic"
|
"sync/atomic"
|
||||||
"time"
|
"time"
|
||||||
@@ -21,10 +21,8 @@ import (
|
|||||||
//
|
//
|
||||||
// It is a shortcut for Decoder.Decode() with the default options.
|
// It is a shortcut for Decoder.Decode() with the default options.
|
||||||
func Unmarshal(data []byte, v interface{}) error {
|
func Unmarshal(data []byte, v interface{}) error {
|
||||||
p := unstable.Parser{}
|
d := decoder{}
|
||||||
p.Reset(data)
|
d.p.Reset(data)
|
||||||
d := decoder{p: &p}
|
|
||||||
|
|
||||||
return d.FromParser(v)
|
return d.FromParser(v)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -61,7 +59,7 @@ func (d *Decoder) DisallowUnknownFields() *Decoder {
|
|||||||
//
|
//
|
||||||
// With this feature enabled, types implementing the unstable/Unmarshaler
|
// With this feature enabled, types implementing the unstable/Unmarshaler
|
||||||
// interface can be decoded from any structure of the document. It allows types
|
// interface can be decoded from any structure of the document. It allows types
|
||||||
// that don't have a straightfoward TOML representation to provide their own
|
// that don't have a straightforward TOML representation to provide their own
|
||||||
// decoding logic.
|
// decoding logic.
|
||||||
//
|
//
|
||||||
// Currently, types can only decode from a single value. Tables and array tables
|
// Currently, types can only decode from a single value. Tables and array tables
|
||||||
@@ -117,27 +115,25 @@ func (d *Decoder) EnableUnmarshalerInterface() *Decoder {
|
|||||||
// Inline Table -> same as Table
|
// Inline Table -> same as Table
|
||||||
// Array of Tables -> same as Array and Table
|
// Array of Tables -> same as Array and Table
|
||||||
func (d *Decoder) Decode(v interface{}) error {
|
func (d *Decoder) Decode(v interface{}) error {
|
||||||
b, err := ioutil.ReadAll(d.r)
|
b, err := io.ReadAll(d.r)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return fmt.Errorf("toml: %w", err)
|
return fmt.Errorf("toml: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
p := unstable.Parser{}
|
|
||||||
p.Reset(b)
|
|
||||||
dec := decoder{
|
dec := decoder{
|
||||||
p: &p,
|
|
||||||
strict: strict{
|
strict: strict{
|
||||||
Enabled: d.strict,
|
Enabled: d.strict,
|
||||||
},
|
},
|
||||||
unmarshalerInterface: d.unmarshalerInterface,
|
unmarshalerInterface: d.unmarshalerInterface,
|
||||||
}
|
}
|
||||||
|
dec.p.Reset(b)
|
||||||
|
|
||||||
return dec.FromParser(v)
|
return dec.FromParser(v)
|
||||||
}
|
}
|
||||||
|
|
||||||
type decoder struct {
|
type decoder struct {
|
||||||
// Which parser instance in use for this decoding session.
|
// Which parser instance in use for this decoding session.
|
||||||
p *unstable.Parser
|
p unstable.Parser
|
||||||
|
|
||||||
// Flag indicating that the current expression is stashed.
|
// Flag indicating that the current expression is stashed.
|
||||||
// If set to true, calling nextExpr will not actually pull a new expression
|
// If set to true, calling nextExpr will not actually pull a new expression
|
||||||
@@ -420,15 +416,39 @@ func (d *decoder) handleArrayTableCollection(key unstable.Iterator, v reflect.Va
|
|||||||
|
|
||||||
return v, nil
|
return v, nil
|
||||||
case reflect.Slice:
|
case reflect.Slice:
|
||||||
elem := v.Index(v.Len() - 1)
|
// Create a new element when the slice is empty; otherwise operate on
|
||||||
|
// the last element.
|
||||||
|
var (
|
||||||
|
elem reflect.Value
|
||||||
|
created bool
|
||||||
|
)
|
||||||
|
if v.Len() == 0 {
|
||||||
|
created = true
|
||||||
|
elemType := v.Type().Elem()
|
||||||
|
if elemType.Kind() == reflect.Interface {
|
||||||
|
elem = makeMapStringInterface()
|
||||||
|
} else {
|
||||||
|
elem = reflect.New(elemType).Elem()
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
elem = v.Index(v.Len() - 1)
|
||||||
|
}
|
||||||
|
|
||||||
x, err := d.handleArrayTable(key, elem)
|
x, err := d.handleArrayTable(key, elem)
|
||||||
if err != nil || d.skipUntilTable {
|
if err != nil || d.skipUntilTable {
|
||||||
return reflect.Value{}, err
|
return reflect.Value{}, err
|
||||||
}
|
}
|
||||||
if x.IsValid() {
|
if x.IsValid() {
|
||||||
elem.Set(x)
|
if created {
|
||||||
|
elem = x
|
||||||
|
} else {
|
||||||
|
elem.Set(x)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if created {
|
||||||
|
return reflect.Append(v, elem), nil
|
||||||
|
}
|
||||||
return v, err
|
return v, err
|
||||||
case reflect.Array:
|
case reflect.Array:
|
||||||
idx := d.arrayIndex(false, v)
|
idx := d.arrayIndex(false, v)
|
||||||
@@ -1014,7 +1034,7 @@ func (d *decoder) unmarshalInteger(value *unstable.Node, v reflect.Value) error
|
|||||||
case reflect.Interface:
|
case reflect.Interface:
|
||||||
r = reflect.ValueOf(i)
|
r = reflect.ValueOf(i)
|
||||||
default:
|
default:
|
||||||
return unstable.NewParserError(d.p.Raw(value.Raw), d.typeMismatchString("integer", v.Type()))
|
return unstable.NewParserError(d.p.Raw(value.Raw), "%s", d.typeMismatchString("integer", v.Type()))
|
||||||
}
|
}
|
||||||
|
|
||||||
if !r.Type().AssignableTo(v.Type()) {
|
if !r.Type().AssignableTo(v.Type()) {
|
||||||
@@ -1033,7 +1053,7 @@ func (d *decoder) unmarshalString(value *unstable.Node, v reflect.Value) error {
|
|||||||
case reflect.Interface:
|
case reflect.Interface:
|
||||||
v.Set(reflect.ValueOf(string(value.Data)))
|
v.Set(reflect.ValueOf(string(value.Data)))
|
||||||
default:
|
default:
|
||||||
return unstable.NewParserError(d.p.Raw(value.Raw), d.typeMismatchString("string", v.Type()))
|
return unstable.NewParserError(d.p.Raw(value.Raw), "%s", d.typeMismatchString("string", v.Type()))
|
||||||
}
|
}
|
||||||
|
|
||||||
return nil
|
return nil
|
||||||
@@ -1078,12 +1098,39 @@ func (d *decoder) keyFromData(keyType reflect.Type, data []byte) (reflect.Value,
|
|||||||
}
|
}
|
||||||
return mk, nil
|
return mk, nil
|
||||||
|
|
||||||
case reflect.PtrTo(keyType).Implements(textUnmarshalerType):
|
case reflect.PointerTo(keyType).Implements(textUnmarshalerType):
|
||||||
mk := reflect.New(keyType)
|
mk := reflect.New(keyType)
|
||||||
if err := mk.Interface().(encoding.TextUnmarshaler).UnmarshalText(data); err != nil {
|
if err := mk.Interface().(encoding.TextUnmarshaler).UnmarshalText(data); err != nil {
|
||||||
return reflect.Value{}, fmt.Errorf("toml: error unmarshalling key type %s from text: %w", stringType, err)
|
return reflect.Value{}, fmt.Errorf("toml: error unmarshalling key type %s from text: %w", stringType, err)
|
||||||
}
|
}
|
||||||
return mk.Elem(), nil
|
return mk.Elem(), nil
|
||||||
|
|
||||||
|
case keyType.Kind() == reflect.Int || keyType.Kind() == reflect.Int8 || keyType.Kind() == reflect.Int16 || keyType.Kind() == reflect.Int32 || keyType.Kind() == reflect.Int64:
|
||||||
|
key, err := strconv.ParseInt(string(data), 10, 64)
|
||||||
|
if err != nil {
|
||||||
|
return reflect.Value{}, fmt.Errorf("toml: error parsing key of type %s from integer: %w", stringType, err)
|
||||||
|
}
|
||||||
|
return reflect.ValueOf(key).Convert(keyType), nil
|
||||||
|
case keyType.Kind() == reflect.Uint || keyType.Kind() == reflect.Uint8 || keyType.Kind() == reflect.Uint16 || keyType.Kind() == reflect.Uint32 || keyType.Kind() == reflect.Uint64:
|
||||||
|
key, err := strconv.ParseUint(string(data), 10, 64)
|
||||||
|
if err != nil {
|
||||||
|
return reflect.Value{}, fmt.Errorf("toml: error parsing key of type %s from unsigned integer: %w", stringType, err)
|
||||||
|
}
|
||||||
|
return reflect.ValueOf(key).Convert(keyType), nil
|
||||||
|
|
||||||
|
case keyType.Kind() == reflect.Float32:
|
||||||
|
key, err := strconv.ParseFloat(string(data), 32)
|
||||||
|
if err != nil {
|
||||||
|
return reflect.Value{}, fmt.Errorf("toml: error parsing key of type %s from float: %w", stringType, err)
|
||||||
|
}
|
||||||
|
return reflect.ValueOf(float32(key)), nil
|
||||||
|
|
||||||
|
case keyType.Kind() == reflect.Float64:
|
||||||
|
key, err := strconv.ParseFloat(string(data), 64)
|
||||||
|
if err != nil {
|
||||||
|
return reflect.Value{}, fmt.Errorf("toml: error parsing key of type %s from float: %w", stringType, err)
|
||||||
|
}
|
||||||
|
return reflect.ValueOf(float64(key)), nil
|
||||||
}
|
}
|
||||||
return reflect.Value{}, fmt.Errorf("toml: cannot convert map key of type %s to expected type %s", stringType, keyType)
|
return reflect.Value{}, fmt.Errorf("toml: cannot convert map key of type %s to expected type %s", stringType, keyType)
|
||||||
}
|
}
|
||||||
@@ -1131,6 +1178,17 @@ func (d *decoder) handleKeyValuePart(key unstable.Iterator, value *unstable.Node
|
|||||||
case reflect.Struct:
|
case reflect.Struct:
|
||||||
path, found := structFieldPath(v, string(key.Node().Data))
|
path, found := structFieldPath(v, string(key.Node().Data))
|
||||||
if !found {
|
if !found {
|
||||||
|
// If no matching struct field is found but the target implements the
|
||||||
|
// unstable.Unmarshaler interface (and it is enabled), delegate the
|
||||||
|
// decoding of this value to the custom unmarshaler.
|
||||||
|
if d.unmarshalerInterface {
|
||||||
|
if v.CanAddr() && v.Addr().CanInterface() {
|
||||||
|
if outi, ok := v.Addr().Interface().(unstable.Unmarshaler); ok {
|
||||||
|
return reflect.Value{}, outi.UnmarshalTOML(value)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// Otherwise, keep previous behavior and skip until the next table.
|
||||||
d.skipUntilTable = true
|
d.skipUntilTable = true
|
||||||
break
|
break
|
||||||
}
|
}
|
||||||
|
|||||||
+579
-139
File diff suppressed because it is too large
Load Diff
+1
-1
@@ -89,7 +89,7 @@ func (n *Node) Next() *Node {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Child returns a pointer to the first child node of this node. Other children
|
// Child returns a pointer to the first child node of this node. Other children
|
||||||
// can be accessed calling Next on the first child. Returns an nil if this Node
|
// can be accessed calling Next on the first child. Returns nil if this Node
|
||||||
// has no child.
|
// has no child.
|
||||||
func (n *Node) Child() *Node {
|
func (n *Node) Child() *Node {
|
||||||
if n.child == 0 {
|
if n.child == 0 {
|
||||||
|
|||||||
+1
-1
@@ -1076,7 +1076,7 @@ byteLoop:
|
|||||||
}
|
}
|
||||||
case c == 'T' || c == 't' || c == ':' || c == '.':
|
case c == 'T' || c == 't' || c == ':' || c == '.':
|
||||||
hasTime = true
|
hasTime = true
|
||||||
case c == '+' || c == '-' || c == 'Z' || c == 'z':
|
case c == '+' || c == 'Z' || c == 'z':
|
||||||
hasTz = true
|
hasTz = true
|
||||||
case c == ' ':
|
case c == ' ':
|
||||||
if !seenSpace && i+1 < len(b) && isDigit(b[i+1]) {
|
if !seenSpace && i+1 < len(b) && isDigit(b[i+1]) {
|
||||||
|
|||||||
@@ -6,7 +6,7 @@ import (
|
|||||||
"strings"
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
|
|
||||||
"github.com/stretchr/testify/require"
|
"github.com/pelletier/go-toml/v2/internal/assert"
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestParser_AST_Numbers(t *testing.T) {
|
func TestParser_AST_Numbers(t *testing.T) {
|
||||||
@@ -141,9 +141,9 @@ func TestParser_AST_Numbers(t *testing.T) {
|
|||||||
p.NextExpression()
|
p.NextExpression()
|
||||||
err := p.Error()
|
err := p.Error()
|
||||||
if e.err {
|
if e.err {
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
} else {
|
} else {
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
expected := astNode{
|
expected := astNode{
|
||||||
Kind: KeyValue,
|
Kind: KeyValue,
|
||||||
@@ -168,8 +168,8 @@ type (
|
|||||||
|
|
||||||
func compareNode(t *testing.T, e astNode, n *Node) {
|
func compareNode(t *testing.T, e astNode, n *Node) {
|
||||||
t.Helper()
|
t.Helper()
|
||||||
require.Equal(t, e.Kind, n.Kind)
|
assert.Equal(t, e.Kind, n.Kind)
|
||||||
require.Equal(t, e.Data, n.Data)
|
assert.Equal(t, e.Data, n.Data)
|
||||||
|
|
||||||
compareIterator(t, e.Children, n.Children())
|
compareIterator(t, e.Children, n.Children())
|
||||||
}
|
}
|
||||||
@@ -341,9 +341,9 @@ func TestParser_AST(t *testing.T) {
|
|||||||
p.NextExpression()
|
p.NextExpression()
|
||||||
err := p.Error()
|
err := p.Error()
|
||||||
if e.err {
|
if e.err {
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
} else {
|
} else {
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
compareNode(t, e.ast, p.Expression())
|
compareNode(t, e.ast, p.Expression())
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
@@ -431,9 +431,9 @@ func TestParser_AST_DateTimes(t *testing.T) {
|
|||||||
p.NextExpression()
|
p.NextExpression()
|
||||||
err := p.Error()
|
err := p.Error()
|
||||||
if e.err {
|
if e.err {
|
||||||
require.Error(t, err)
|
assert.Error(t, err)
|
||||||
} else {
|
} else {
|
||||||
require.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|
||||||
expected := astNode{
|
expected := astNode{
|
||||||
Kind: KeyValue,
|
Kind: KeyValue,
|
||||||
|
|||||||
Reference in New Issue
Block a user