As recommended, an `internal/assert` package was added with a reduced set of assertions. All tests were then refactored to use the internal assertions. When more complex assertions were used, they have been rewritten using logic and the simplified assertions.
Fancy formatting for failures was omitted. The `internal/assert/assertions.diff` function could be overwritten for better formatting. That is where diff libraries are used in other test suites.
Refs: #872
Co-authored-by: Alex Mikitik <alex.mikitik@oracle.com>
* Update Travis CI to use latest Go releases
* Fix go vet issues for Go 1.10
Starting in Go 1.10, the `go test` command now automatically runs `go
vet`. This commit fixes two issues flagged by vet that cause `go test`
to fail.
* Fix gofmt issue for Go 1.10
Go 1.10 introduced a small formatting change with comments in empty
multiline slice definitions. This commit attempts to move the offending
comment in such a way that all version of gofmt will agree on its
location.
* Remove go-vet from test.sh
Starting in Go 1.10, the `go test` command automatically runs `go vet`,
so we don't need to run `go vet` explicitly from within test.sh.
Fixes#222
ostiwe
Alex Mikitik