Fixes #22: Fixes style issues

This commit is contained in:
Thomas Pelletier
2014-08-29 18:24:51 +02:00
parent a2495b4806
commit fb5423fba2
4 changed files with 114 additions and 115 deletions
+25 -25
View File
@@ -94,7 +94,7 @@ func parseStart(p *parser) parserStateFn {
}
func parseGroupArray(p *parser) parserStateFn {
start_token := p.getToken() // discard the [[
startToken := p.getToken() // discard the [[
key := p.getToken()
if key.typ != tokenKeyGroupArray {
p.raiseError(key, "unexpected token %s, was expecting a key group array", key)
@@ -103,21 +103,21 @@ func parseGroupArray(p *parser) parserStateFn {
// get or create group array element at the indicated part in the path
keys := strings.Split(key.val, ".")
p.tree.createSubTree(keys[:len(keys)-1]) // create parent entries
dest_tree := p.tree.GetPath(keys)
destTree := p.tree.GetPath(keys)
var array []*TomlTree
if dest_tree == nil {
if destTree == nil {
array = make([]*TomlTree, 0)
} else if dest_tree.([]*TomlTree) != nil {
array = dest_tree.([]*TomlTree)
} else if destTree.([]*TomlTree) != nil {
array = destTree.([]*TomlTree)
} else {
p.raiseError(key, "key %s is already assigned and not of type group array", key)
}
p.currentGroup = keys
// add a new tree to the end of the group array
new_tree := newTomlTree()
new_tree.position = start_token.Position
array = append(array, new_tree)
newTree := newTomlTree()
newTree.position = startToken.Position
array = append(array, newTree)
p.tree.SetPath(p.currentGroup, array)
// remove all keys that were children of this group array
@@ -144,7 +144,7 @@ func parseGroupArray(p *parser) parserStateFn {
}
func parseGroup(p *parser) parserStateFn {
start_token := p.getToken() // discard the [
startToken := p.getToken() // discard the [
key := p.getToken()
if key.typ != tokenKeyGroup {
p.raiseError(key, "unexpected token %s, was expecting a key group", key)
@@ -162,8 +162,8 @@ func parseGroup(p *parser) parserStateFn {
}
p.assume(tokenRightBracket)
p.currentGroup = keys
target_tree := p.tree.GetPath(p.currentGroup).(*TomlTree)
target_tree.position = start_token.Position
targetTree := p.tree.GetPath(p.currentGroup).(*TomlTree)
targetTree.position = startToken.Position
return parseStart(p)
}
@@ -171,33 +171,33 @@ func parseAssign(p *parser) parserStateFn {
key := p.getToken()
p.assume(tokenEqual)
value := parseRvalue(p)
var group_key []string
var groupKey []string
if len(p.currentGroup) > 0 {
group_key = p.currentGroup
groupKey = p.currentGroup
} else {
group_key = []string{}
groupKey = []string{}
}
// find the group to assign, looking out for arrays of groups
var target_node *TomlTree
switch node := p.tree.GetPath(group_key).(type) {
var targetNode *TomlTree
switch node := p.tree.GetPath(groupKey).(type) {
case []*TomlTree:
target_node = node[len(node)-1]
targetNode = node[len(node)-1]
case *TomlTree:
target_node = node
targetNode = node
default:
p.raiseError(key, "Unknown group type for path: %s",
strings.Join(group_key, "."))
strings.Join(groupKey, "."))
}
// assign value to the found group
local_key := []string{key.val}
final_key := append(group_key, key.val)
if target_node.GetPath(local_key) != nil {
localKey := []string{key.val}
finalKey := append(groupKey, key.val)
if targetNode.GetPath(localKey) != nil {
p.raiseError(key, "The following key was defined twice: %s",
strings.Join(final_key, "."))
strings.Join(finalKey, "."))
}
target_node.values[key.val] = &tomlValue{value, key.Position}
targetNode.values[key.val] = &tomlValue{value, key.Position}
return parseStart(p)
}
@@ -244,7 +244,7 @@ func parseRvalue(p *parser) interface{} {
}
func parseArray(p *parser) []interface{} {
array := make([]interface{}, 0)
var array []interface{}
arrayType := reflect.TypeOf(nil)
for {
follow := p.peek()