time: follow RFC3339 spec for datetime (#632)

This commit is contained in:
Johanan Idicula
2021-10-18 09:56:07 -04:00
committed by GitHub
parent 9e81ce1c33
commit df4bb061f8
3 changed files with 3 additions and 4 deletions
+1 -1
View File
@@ -97,7 +97,7 @@ func (d LocalDateTime) AsTime(zone *time.Location) time.Time {
// String returns RFC 3339 representation of d. // String returns RFC 3339 representation of d.
func (d LocalDateTime) String() string { func (d LocalDateTime) String() string {
return d.LocalDate.String() + " " + d.LocalTime.String() return d.LocalDate.String() + "T" + d.LocalTime.String()
} }
// MarshalText returns RFC 3339 representation of d. // MarshalText returns RFC 3339 representation of d.
+2 -2
View File
@@ -88,7 +88,7 @@ func TestLocalDateTime_String(t *testing.T) {
toml.LocalDate{2021, 6, 8}, toml.LocalDate{2021, 6, 8},
toml.LocalTime{20, 12, 1, 2, 9}, toml.LocalTime{20, 12, 1, 2, 9},
} }
require.Equal(t, "2021-06-08 20:12:01.000000002", d.String()) require.Equal(t, "2021-06-08T20:12:01.000000002", d.String())
} }
func TestLocalDateTime_MarshalText(t *testing.T) { func TestLocalDateTime_MarshalText(t *testing.T) {
@@ -98,7 +98,7 @@ func TestLocalDateTime_MarshalText(t *testing.T) {
} }
b, err := d.MarshalText() b, err := d.MarshalText()
require.NoError(t, err) require.NoError(t, err)
require.Equal(t, []byte("2021-06-08 20:12:01.000000002"), b) require.Equal(t, []byte("2021-06-08T20:12:01.000000002"), b)
} }
func TestLocalDateTime_UnmarshalMarshalText(t *testing.T) { func TestLocalDateTime_UnmarshalMarshalText(t *testing.T) {
-1
View File
@@ -1107,7 +1107,6 @@ func TestTOMLTest_Valid_Datetime_LocalTime(t *testing.T) {
} }
func TestTOMLTest_Valid_Datetime_Local(t *testing.T) { func TestTOMLTest_Valid_Datetime_Local(t *testing.T) {
t.Skip("FIXME")
input := "local = 1987-07-05T17:45:00\nmilli = 1977-12-21T10:32:00.555\nspace = 1987-07-05 17:45:00\n" input := "local = 1987-07-05T17:45:00\nmilli = 1977-12-21T10:32:00.555\nspace = 1987-07-05 17:45:00\n"
jsonRef := "{\n \"local\": {\n \"type\": \"datetime-local\",\n \"value\": \"1987-07-05T17:45:00\"\n },\n \"milli\": {\n \"type\": \"datetime-local\",\n \"value\": \"1977-12-21T10:32:00.555\"\n },\n \"space\": {\n \"type\": \"datetime-local\",\n \"value\": \"1987-07-05T17:45:00\"\n }\n}\n" jsonRef := "{\n \"local\": {\n \"type\": \"datetime-local\",\n \"value\": \"1987-07-05T17:45:00\"\n },\n \"milli\": {\n \"type\": \"datetime-local\",\n \"value\": \"1977-12-21T10:32:00.555\"\n },\n \"space\": {\n \"type\": \"datetime-local\",\n \"value\": \"1987-07-05T17:45:00\"\n }\n}\n"
testgenValid(t, input, jsonRef) testgenValid(t, input, jsonRef)