Upgrade to golangci-lint v2 (#1008)

This commit is contained in:
Nathan Baulch
2026-01-05 01:54:29 +11:00
committed by GitHub
parent 9702fae9b8
commit a675c6b3e2
45 changed files with 568 additions and 649 deletions
+20 -21
View File
@@ -1,21 +1,21 @@
// Package danger provides optimized unsafe functions.
package danger
import (
"fmt"
"reflect"
"unsafe"
)
const maxInt = uintptr(int(^uint(0) >> 1))
func SubsliceOffset(data []byte, subslice []byte) int {
datap := (*reflect.SliceHeader)(unsafe.Pointer(&data))
hlp := (*reflect.SliceHeader)(unsafe.Pointer(&subslice))
datap := uintptr(unsafe.Pointer(unsafe.SliceData(data))) // #nosec G103
hlp := uintptr(unsafe.Pointer(unsafe.SliceData(subslice))) // #nosec G103
if hlp.Data < datap.Data {
panic(fmt.Errorf("subslice address (%d) is before data address (%d)", hlp.Data, datap.Data))
if hlp < datap {
panic(fmt.Errorf("subslice address (%d) is before data address (%d)", hlp, datap))
}
offset := hlp.Data - datap.Data
offset := hlp - datap
if offset > maxInt {
panic(fmt.Errorf("slice offset larger than int (%d)", offset))
@@ -23,12 +23,12 @@ func SubsliceOffset(data []byte, subslice []byte) int {
intoffset := int(offset)
if intoffset > datap.Len {
panic(fmt.Errorf("slice offset (%d) is farther than data length (%d)", intoffset, datap.Len))
if intoffset > len(data) {
panic(fmt.Errorf("slice offset (%d) is farther than data length (%d)", intoffset, len(data)))
}
if intoffset+hlp.Len > datap.Len {
panic(fmt.Errorf("slice ends (%d+%d) is farther than data length (%d)", intoffset, hlp.Len, datap.Len))
if intoffset+len(subslice) > len(data) {
panic(fmt.Errorf("slice ends (%d+%d) is farther than data length (%d)", intoffset, len(subslice), len(data)))
}
return intoffset
@@ -38,28 +38,27 @@ func BytesRange(start []byte, end []byte) []byte {
if start == nil || end == nil {
panic("cannot call BytesRange with nil")
}
startp := (*reflect.SliceHeader)(unsafe.Pointer(&start))
endp := (*reflect.SliceHeader)(unsafe.Pointer(&end))
if startp.Data > endp.Data {
panic(fmt.Errorf("start pointer address (%d) is after end pointer address (%d)", startp.Data, endp.Data))
startp := uintptr(unsafe.Pointer(unsafe.SliceData(start))) // #nosec G103
endp := uintptr(unsafe.Pointer(unsafe.SliceData(end))) // #nosec G103
if startp > endp {
panic(fmt.Errorf("start pointer address (%d) is after end pointer address (%d)", startp, endp))
}
l := startp.Len
endLen := int(endp.Data-startp.Data) + endp.Len
l := len(start)
endLen := int(endp-startp) + len(end)
if endLen > l {
l = endLen
}
if l > startp.Cap {
panic(fmt.Errorf("range length is larger than capacity"))
if l > cap(start) {
panic("range length is larger than capacity")
}
return start[:l]
}
func Stride(ptr unsafe.Pointer, size uintptr, offset int) unsafe.Pointer {
// TODO: replace with unsafe.Add when Go 1.17 is released
// https://github.com/golang/go/issues/40481
return unsafe.Pointer(uintptr(ptr) + uintptr(int(size)*offset))
return unsafe.Add(ptr, size*uintptr(offset))
}