Remove optional offset and fallback, guarantee offset by construction

ParserError.Offset is now a plain exported int field, always set:
- The parser sets it via setErrOffset() when capturing parse errors
- strict.go sets it from the key's Raw range at construction
- wrapDecodeError computes it inline from cap(document) - cap(highlight)

This eliminates:
- The SetOffset/Offset() accessor methods and offsetValid flag
- The subsliceOffset fallback function in errors.go
- Any conditional logic around whether the offset is present

The offset is guaranteed by construction at every path that creates
or consumes a ParserError.

Co-authored-by: Thomas Pelletier <thomas@pelletier.dev>

This commit is contained in:

Cursor Agent

2026-04-12 17:25:32 +00:00

parent f7136d052b

commit 96ac48eb74

5 changed files with 22 additions and 50 deletions

									
										errors_test.go
									
		+1
		
												View File
												
				@@ -172,6 +172,7 @@ line 5`,

							err := wrapDecodeError(doc, &unstable.ParserError{

								Highlight: hl,

								Message:   e.msg,

								Offset:    start,

							})

							var derr *DecodeError